Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1781663004: Allow null begin frame sources in cc::Scheduler (Closed)

Created:
4 years, 9 months ago by enne (OOO)
Modified:
4 years, 9 months ago
Reviewers:
sunnyps, Sami
CC:
cc-bugs_chromium.org, chromium-reviews, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@scheduler_change_begin_frame_source
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow null begin frame sources in cc::Scheduler This adds support to make it possible to set the begin frame source in Scheduler back to null before setting it to something else again. This is primarily to support the use case of losing an output surface (which will provide the begin frame source) before asynchronously later initializing another output surface (with potentially another source). In this case, there will be some period of time where there is no valid begin frame source. The scheduler owner could provide a fake one, but I think that's more confusing than helpful. Depends on https://codereview.chromium.org/1774323003 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/0ec0805af79680611fbfbc5d0e825eb18039cf9d Cr-Commit-Position: refs/heads/master@{#382016}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -10 lines) Patch
M cc/scheduler/scheduler.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/scheduler/scheduler.cc View 6 chunks +13 lines, -8 lines 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 1 chunk +51 lines, -0 lines 0 comments Download
M cc/test/scheduler_test_common.h View 1 chunk +3 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
enne (OOO)
4 years, 9 months ago (2016-03-10 00:07:14 UTC) #3
Sami
lgtm.
4 years, 9 months ago (2016-03-14 16:12:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781663004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781663004/1
4 years, 9 months ago (2016-03-18 17:16:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 18:22:53 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 18:24:29 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ec0805af79680611fbfbc5d0e825eb18039cf9d
Cr-Commit-Position: refs/heads/master@{#382016}

Powered by Google App Engine
This is Rietveld 408576698