Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1781653005: Stage restrictive declarations flag (Closed)

Created:
4 years, 9 months ago by Dan Ehrenberg
Modified:
4 years, 9 months ago
Reviewers:
adamk
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Stage restrictive declarations flag This flag bans illegal (and likely useless) constructs like for (;;) function f() {} R=adamk BUG=v8:4824 LOG=Y Committed: https://crrev.com/7297f018e7bcbb01b8a1756ed5f653af3a9d9287 Cr-Commit-Position: refs/heads/master@{#34646}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/flag-definitions.h View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781653005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781653005/1
4 years, 9 months ago (2016-03-09 22:33:25 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-09 23:00:20 UTC) #5
Dan Ehrenberg
4 years, 9 months ago (2016-03-09 23:50:23 UTC) #6
adamk
lgtm
4 years, 9 months ago (2016-03-09 23:51:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781653005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781653005/1
4 years, 9 months ago (2016-03-10 00:00:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 00:02:31 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 00:05:22 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7297f018e7bcbb01b8a1756ed5f653af3a9d9287
Cr-Commit-Position: refs/heads/master@{#34646}

Powered by Google App Engine
This is Rietveld 408576698