Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1781653002: Fix up picture clip bounds in SkiaServe (Closed)

Created:
4 years, 9 months ago by joshua.litt
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tweaks #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -49 lines) Patch
M tools/skiaserve/Request.h View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/skiaserve/Request.cpp View 1 8 chunks +48 lines, -11 lines 2 comments Download
M tools/skiaserve/urlhandlers/BreakHandler.cpp View 3 chunks +2 lines, -15 lines 0 comments Download
M tools/skiaserve/urlhandlers/DownloadHandler.cpp View 2 chunks +1 line, -18 lines 0 comments Download
M tools/skiaserve/urlhandlers/UrlHandler.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
joshualitt
ptal https://codereview.chromium.org/1781653002/diff/20001/tools/skiaserve/Request.cpp File tools/skiaserve/Request.cpp (right): https://codereview.chromium.org/1781653002/diff/20001/tools/skiaserve/Request.cpp#newcode269 tools/skiaserve/Request.cpp:269: uint8_t* start = ((uint8_t*) bitmap->getPixels()) + (y * ...
4 years, 9 months ago (2016-03-09 15:34:47 UTC) #4
ethannicholas
lgtm https://codereview.chromium.org/1781653002/diff/20001/tools/skiaserve/Request.cpp File tools/skiaserve/Request.cpp (right): https://codereview.chromium.org/1781653002/diff/20001/tools/skiaserve/Request.cpp#newcode269 tools/skiaserve/Request.cpp:269: uint8_t* start = ((uint8_t*) bitmap->getPixels()) + (y * ...
4 years, 9 months ago (2016-03-09 16:32:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781653002/20001
4 years, 9 months ago (2016-03-09 16:33:01 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 18:07:05 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e0449cf9f43e179a809eb1b87ca3bf77cf6f1222

Powered by Google App Engine
This is Rietveld 408576698