Remove Mac Valgrind from the memory.fyi waterfall.

Remove Mac Valgrind from the memory.fyi waterfall.

These bots require Mac OSX 10.6, which isn't supported by Chromium
anymore.

BUG=593920
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299241

[benwells, 2016-03-11 02:45:30]

benwells@chromium.org changed reviewers:
+ dpranke@chromium.org

[benwells, 2016-03-11 02:45:30]

dpranke: this is my first change in this repo. Not sure if you're the right
reviewer or not.

Also not sure what the dependencies are on the chromium repo, which also has
references to mac valgrind. I'm guessing I remove it here first, then clean up
chromium.

[benwells, 2016-03-11 02:47:42]

benwells@chromium.org changed reviewers:
+ thestig@chromium.org

[Dirk Pranke, 2016-03-11 02:49:08]

I'm a reasonable reviewer for this, and it LGTM.

Once this lands you'll need to file tickets to restart the master and have
infra-labs reclaim the no-longer-needed slaves. 

I think (but am not positive) the only real sign of this stuff in src/-land is
the target in build/all.gyp that can be removed. There may be some additional
mac-specific stuff in //tools/valgrind that can also be deleted.

[benwells, 2016-03-11 02:59:01]

On 2016/03/11 02:49:08, Dirk Pranke wrote:
> I'm a reasonable reviewer for this, and it LGTM.
> 
> Once this lands you'll need to file tickets to restart the master and have
> infra-labs reclaim the no-longer-needed slaves. 
> 
> I think (but am not positive) the only real sign of this stuff in src/-land is
> the target in build/all.gyp that can be removed. There may be some additional
> mac-specific stuff in //tools/valgrind that can also be deleted.

dpranke: is there any way to test these kind of changes before making them live?

[Dirk Pranke, 2016-03-11 03:03:43]

On 2016/03/11 02:59:01, benwells wrote:
> On 2016/03/11 02:49:08, Dirk Pranke wrote:
> > I'm a reasonable reviewer for this, and it LGTM.
> > 
> > Once this lands you'll need to file tickets to restart the master and have
> > infra-labs reclaim the no-longer-needed slaves. 
> > 
> > I think (but am not positive) the only real sign of this stuff in src/-land
is
> > the target in build/all.gyp that can be removed. There may be some
additional
> > mac-specific stuff in //tools/valgrind that can also be deleted.
> 
> dpranke: is there any way to test these kind of changes before making them
live?

Short of trying to run the buildbot master yourself, no.

Running a buildbot master locally is not that hard, though. See:

https://www.chromium.org/developers/testing/chromium-build-infrastructure/get...
https://www.chromium.org/developers/testing/chromium-build-infrastructure/get...
https://www.chromium.org/developers/testing/chromium-build-infrastructure/get...

That said, this change is fairly straightforward and I would be comfortable with
you landing it as-is.

[benwells, 2016-03-11 03:09:54]

The CQ bit was checked by benwells@chromium.org

[commit-bot: I haz the power, 2016-03-11 03:10:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1781643006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1781643006/1

[benwells, 2016-03-11 03:10:32]

On 2016/03/11 03:03:43, Dirk Pranke wrote:
> On 2016/03/11 02:59:01, benwells wrote:
> > On 2016/03/11 02:49:08, Dirk Pranke wrote:
> > > I'm a reasonable reviewer for this, and it LGTM.
> > > 
> > > Once this lands you'll need to file tickets to restart the master and have
> > > infra-labs reclaim the no-longer-needed slaves. 
> > > 
> > > I think (but am not positive) the only real sign of this stuff in
src/-land
> is
> > > the target in build/all.gyp that can be removed. There may be some
> additional
> > > mac-specific stuff in //tools/valgrind that can also be deleted.
> > 
> > dpranke: is there any way to test these kind of changes before making them
> live?
> 
> Short of trying to run the buildbot master yourself, no.
> 
> Running a buildbot master locally is not that hard, though. See:
> 
>
https://www.chromium.org/developers/testing/chromium-build-infrastructure/get...
>
https://www.chromium.org/developers/testing/chromium-build-infrastructure/get...
>
https://www.chromium.org/developers/testing/chromium-build-infrastructure/get...
> 
> That said, this change is fairly straightforward and I would be comfortable
with
> you landing it as-is.

Great, commit box checked :)

[commit-bot: I haz the power, 2016-03-11 03:15:25]

Description was changed from

==========
Remove Mac Valgrind from the memory.fyi waterfall.

These bots require Mac OSX 10.6, which isn't supported by Chromium
anymore.

BUG=593920
==========

to

==========
Remove Mac Valgrind from the memory.fyi waterfall.

These bots require Mac OSX 10.6, which isn't supported by Chromium
anymore.

BUG=593920

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299241
==========

[commit-bot: I haz the power, 2016-03-11 03:15:26]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299241