Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1781603002: [telemetry] Add TodoMVC examples based test for V8 to telemetry (Closed)

Created:
4 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 9 months ago
CC:
chromium-reviews, eakuefner, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[telemetry] Add TodoMVC examples based test for V8 to telemetry BUG=593406 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect Committed: https://crrev.com/b05b8991eb423b2deba6283856277846b3ef0981 Cr-Commit-Position: refs/heads/master@{#380221}

Patch Set 1 #

Total comments: 6

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -0 lines) Patch
M tools/perf/benchmarks/v8.py View 1 chunk +19 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/todomvc.json View 1 chunk +16 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/todomvc_000.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/todomvc.py View 1 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
jochen (gone - plz use gerrit)
am I doing this right? I took the list from aerotwist's blog post.
4 years, 9 months ago (2016-03-09 14:42:26 UTC) #2
sullivan
cc-ing eakuefner, who's been doing some refactoring in telemetry.
4 years, 9 months ago (2016-03-09 14:44:16 UTC) #4
eakuefner
Code looks fine, just want to ask some questions first :) Is this the mentioned ...
4 years, 9 months ago (2016-03-09 18:08:48 UTC) #6
Sami
Looks great -- couple of minor comments. https://codereview.chromium.org/1781603002/diff/1/tools/perf/benchmarks/v8.py File tools/perf/benchmarks/v8.py (right): https://codereview.chromium.org/1781603002/diff/1/tools/perf/benchmarks/v8.py#newcode139 tools/perf/benchmarks/v8.py:139: return True ...
4 years, 9 months ago (2016-03-09 18:39:02 UTC) #7
jochen (gone - plz use gerrit)
On 2016/03/09 at 18:08:48, eakuefner wrote: > Code looks fine, just want to ask some ...
4 years, 9 months ago (2016-03-09 18:44:37 UTC) #9
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1781603002/diff/1/tools/perf/benchmarks/v8.py File tools/perf/benchmarks/v8.py (right): https://codereview.chromium.org/1781603002/diff/1/tools/perf/benchmarks/v8.py#newcode139 tools/perf/benchmarks/v8.py:139: return True On 2016/03/09 at 18:39:02, Sami wrote: > ...
4 years, 9 months ago (2016-03-09 18:44:43 UTC) #10
Sami
WillBe( lgtm )
4 years, 9 months ago (2016-03-09 18:46:28 UTC) #11
eakuefner
lgtm
4 years, 9 months ago (2016-03-09 18:51:01 UTC) #12
jochen (gone - plz use gerrit)
all comments addressed
4 years, 9 months ago (2016-03-09 18:56:25 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781603002/20001
4 years, 9 months ago (2016-03-09 18:56:48 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-09 21:19:31 UTC) #17
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 21:21:51 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b05b8991eb423b2deba6283856277846b3ef0981
Cr-Commit-Position: refs/heads/master@{#380221}

Powered by Google App Engine
This is Rietveld 408576698