[telemetry] Add TodoMVC examples based test for V8 to telemetry

[telemetry] Add TodoMVC examples based test for V8 to telemetry

BUG=593406
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Committed: https://crrev.com/b05b8991eb423b2deba6283856277846b3ef0981
Cr-Commit-Position: refs/heads/master@{#380221}

[jochen (gone - plz use gerrit), 2016-03-09 14:42:26]

jochen@chromium.org changed reviewers:
+ cbruni@chromium.org, skyostil@chromium.org, ulan@chromium.org

[jochen (gone - plz use gerrit), 2016-03-09 14:42:26]

am I doing this right?

I took the list from aerotwist's blog post.

[sullivan, 2016-03-09 14:44:16]

sullivan@chromium.org changed reviewers:
+ sullivan@chromium.org

[sullivan, 2016-03-09 14:44:16]

cc-ing eakuefner, who's been doing some refactoring in telemetry.

[eakuefner, 2016-03-09 18:08:47]

eakuefner@chromium.org changed reviewers:
+ eakuefner@chromium.org

[eakuefner, 2016-03-09 18:08:48]

Code looks fine, just want to ask some questions first :)

Is this the mentioned blog post?
https://aerotwist.com/blog/the-cost-of-frameworks/

Also, can you summarize why you're adding this benchmark and/or is there a
tracking bug?

[Sami, 2016-03-09 18:39:02]

Looks great -- couple of minor comments.

https://codereview.chromium.org/1781603002/diff/1/tools/perf/benchmarks/v8.py
File tools/perf/benchmarks/v8.py (right):

https://codereview.chromium.org/1781603002/diff/1/tools/perf/benchmarks/v8.py...
tools/perf/benchmarks/v8.py:139: return True
Any particular reason for restarting? It probably makes sense for the memory
cases above but not sure about the numbers you're collecting here.

https://codereview.chromium.org/1781603002/diff/1/tools/perf/page_sets/todomv...
File tools/perf/page_sets/todomvc.py (right):

https://codereview.chromium.org/1781603002/diff/1/tools/perf/page_sets/todomv...
tools/perf/page_sets/todomvc.py:28: credentials_path='data/credentials.json',
It doesn't look like you need to login to any of the pages above so you can drop
this.

https://codereview.chromium.org/1781603002/diff/1/tools/perf/page_sets/todomv...
tools/perf/page_sets/todomvc.py:42: cloud_storage_bucket=story.PARTNER_BUCKET)
Seems like this could be PUBLIC_BUCKET since these are public pages? (You'll
need to re-upload the wpr if you change this, sorry!)

[jochen (gone - plz use gerrit), 2016-03-09 18:43:47]

Description was changed from

==========
[telemetry] Add TodoMVC examples based test for V8 to telemetry

BUG=
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
==========

to

==========
[telemetry] Add TodoMVC examples based test for V8 to telemetry

BUG=593406
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
==========

[jochen (gone - plz use gerrit), 2016-03-09 18:44:37]

On 2016/03/09 at 18:08:48, eakuefner wrote:
> Code looks fine, just want to ask some questions first :)
> 
> Is this the mentioned blog post?
https://aerotwist.com/blog/the-cost-of-frameworks/
> 

yes

> Also, can you summarize why you're adding this benchmark and/or is there a
tracking bug?

filed a bug, referenced it from the CL description, and added the background
info there

[jochen (gone - plz use gerrit), 2016-03-09 18:44:43]

https://codereview.chromium.org/1781603002/diff/1/tools/perf/benchmarks/v8.py
File tools/perf/benchmarks/v8.py (right):

https://codereview.chromium.org/1781603002/diff/1/tools/perf/benchmarks/v8.py...
tools/perf/benchmarks/v8.py:139: return True
On 2016/03/09 at 18:39:02, Sami wrote:
> Any particular reason for restarting? It probably makes sense for the memory
cases above but not sure about the numbers you're collecting here.

using the same renderer will result in some of the stuff coming from the memory
cache, eg. I'd expect that the analytics scripts on all those pages eventually
will come out of the compilation cache.

https://codereview.chromium.org/1781603002/diff/1/tools/perf/page_sets/todomv...
File tools/perf/page_sets/todomvc.py (right):

https://codereview.chromium.org/1781603002/diff/1/tools/perf/page_sets/todomv...
tools/perf/page_sets/todomvc.py:28: credentials_path='data/credentials.json',
On 2016/03/09 at 18:39:02, Sami wrote:
> It doesn't look like you need to login to any of the pages above so you can
drop this.

will do

https://codereview.chromium.org/1781603002/diff/1/tools/perf/page_sets/todomv...
tools/perf/page_sets/todomvc.py:42: cloud_storage_bucket=story.PARTNER_BUCKET)
On 2016/03/09 at 18:39:02, Sami wrote:
> Seems like this could be PUBLIC_BUCKET since these are public pages? (You'll
need to re-upload the wpr if you change this, sorry!)

will do

[Sami, 2016-03-09 18:46:28]

WillBe( lgtm )

[eakuefner, 2016-03-09 18:51:01]

lgtm

[jochen (gone - plz use gerrit), 2016-03-09 18:56:24]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-03-09 18:56:25]

all comments addressed

[jochen (gone - plz use gerrit), 2016-03-09 18:56:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org, skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/1781603002/#ps20001
(title: "updates")

[commit-bot: I haz the power, 2016-03-09 18:56:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1781603002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1781603002/20001

[commit-bot: I haz the power, 2016-03-09 21:19:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-09 21:21:50]

Description was changed from

==========
[telemetry] Add TodoMVC examples based test for V8 to telemetry

BUG=593406
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
==========

to

==========
[telemetry] Add TodoMVC examples based test for V8 to telemetry

BUG=593406
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Committed: https://crrev.com/b05b8991eb423b2deba6283856277846b3ef0981
Cr-Commit-Position: refs/heads/master@{#380221}
==========

[commit-bot: I haz the power, 2016-03-09 21:21:51]

Patchset 2 (id:??) landed as
https://crrev.com/b05b8991eb423b2deba6283856277846b3ef0981
Cr-Commit-Position: refs/heads/master@{#380221}