Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 17816005: Doc server broken link detection (Closed)

Created:
7 years, 6 months ago by jshumway
Modified:
7 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Doc server broken link detection The integration test, when run with -a, now detects and reports broken links and orphaned pages. Broken links either link to an invalid page (404) or have an invalid anchor. Orphaned pages are pages that cannot be navigated to from the home pages just by clicking links. BUG=147747 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212240

Patch Set 1 #

Patch Set 2 : style changes #

Patch Set 3 : Additional information for broken anchor links #

Total comments: 7

Patch Set 4 : patch rewrite #

Total comments: 60

Patch Set 5 : cleanup, special cases, polish #

Total comments: 18

Patch Set 6 : finalization #

Unified diffs Side-by-side diffs Delta from patch set Stats (+387 lines, -18 lines) Patch
M chrome/common/extensions/docs/server2/app.yaml View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/cron.yaml View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/server2/cron_servlet.py View 1 2 3 4 2 chunks +4 lines, -9 lines 0 comments Download
A chrome/common/extensions/docs/server2/file_system_util.py View 1 2 3 4 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/server2/handler.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/integration_test.py View 1 2 3 4 5 4 chunks +52 lines, -1 line 0 comments Download
A chrome/common/extensions/docs/server2/link_error_detector.py View 1 2 3 4 1 chunk +219 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/link_error_detector_test.py View 1 2 3 4 1 chunk +89 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/server2/server_instance.py View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/apps.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/json/apps_sidenav.json View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
jshumway
The good news, we can finally find broken links systematically! The bad new, my test ...
7 years, 6 months ago (2013-06-26 17:49:10 UTC) #1
jshumway
7 years, 5 months ago (2013-06-27 18:46:44 UTC) #2
jshumway
Added an additional bit of output to the report of broken links that contain anchors, ...
7 years, 5 months ago (2013-07-01 18:50:08 UTC) #3
not at google - send to devlin
Some things to go on with. Didn't look at the logic itself in much detail ...
7 years, 5 months ago (2013-07-01 23:16:21 UTC) #4
jshumway
Considerable rewrite, now finds a few more broken links (130) and and detects orphaned pages ...
7 years, 5 months ago (2013-07-05 18:48:48 UTC) #5
not at google - send to devlin
feeling a bit ill doing this on the bus, so sending comments now. https://codereview.chromium.org/17816005/diff/13001/chrome/common/extensions/docs/server2/cron_servlet.py File ...
7 years, 5 months ago (2013-07-09 00:17:32 UTC) #6
jshumway
https://codereview.chromium.org/17816005/diff/13001/chrome/common/extensions/docs/server2/cron_servlet.py File chrome/common/extensions/docs/server2/cron_servlet.py (right): https://codereview.chromium.org/17816005/diff/13001/chrome/common/extensions/docs/server2/cron_servlet.py#newcode27 chrome/common/extensions/docs/server2/cron_servlet.py:27: ''' Create a mapping between all of the files ...
7 years, 5 months ago (2013-07-17 00:49:55 UTC) #7
not at google - send to devlin
lgtm https://codereview.chromium.org/17816005/diff/21001/chrome/common/extensions/docs/server2/integration_test.py File chrome/common/extensions/docs/server2/integration_test.py (right): https://codereview.chromium.org/17816005/diff/21001/chrome/common/extensions/docs/server2/integration_test.py#newcode49 chrome/common/extensions/docs/server2/integration_test.py:49: col_width = max([len(l[0]) for l in broken_links]) the ...
7 years, 5 months ago (2013-07-17 20:19:40 UTC) #8
jshumway
https://codereview.chromium.org/17816005/diff/21001/chrome/common/extensions/docs/server2/integration_test.py File chrome/common/extensions/docs/server2/integration_test.py (right): https://codereview.chromium.org/17816005/diff/21001/chrome/common/extensions/docs/server2/integration_test.py#newcode49 chrome/common/extensions/docs/server2/integration_test.py:49: col_width = max([len(l[0]) for l in broken_links]) On 2013/07/17 ...
7 years, 5 months ago (2013-07-17 22:15:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jaredshumway94@gmail.com/17816005/28002
7 years, 5 months ago (2013-07-17 22:18:23 UTC) #10
commit-bot: I haz the power
7 years, 5 months ago (2013-07-18 04:18:39 UTC) #11
Message was sent while issue was closed.
Change committed as 212240

Powered by Google App Engine
This is Rietveld 408576698