build/common.gypi - Issue 1781593004: Suppress new C4334 and C4595 warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 1781593004: Suppress new C4334 and C4595 warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index e8042fea050ca0797c35939cf401baf0b2a6604e..9c29c846ca908573e02e8294f7f053059ba71c2c 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -5711,6 +5711,11 @@

# TODO(brucedawson): http://crbug.com/554200 4312 is a VS

# 2015 64-bit warning for integer to larger pointer

4312,

+ # TODO(brucedawson): http://crbug.com/593448 4334 is a 'suspicious

+ # shift' warning and 4595 is an 'illegal inline operator new' warning

+ # Both are new in VS 2015 Update 2 and can safely be deferred for now.

+ 4334, 4595,

'msvs_settings': {

'VCCLCompilerTool': {

« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »