Suppress new C4334 and C4595 warnings

Suppress new C4334 and C4595 warnings

These two warnings are new in VS 2015 Update 2 (C4334 isn't necessarily
brand new, but it fires much more frequently now). Therefore they are
preventing a switch to VS 2015, without actually indicating any new
issues. The possible issues pointed to by C4334, in particular, have
been benign in every case that I have investigated. Therefore the
pragmatic thing to do is to suppress them for now, and resolve the
warnings individually after VS 2015 is the default.

The 4595 warning suppression is only needed in third_party\icu but it is
placed globally temporarily.

These warnings are also blocking PGO builds - another reason why a
timely fix is important.

BUG=440500, 593448, 591920
Committed: https://crrev.com/58552f9fcee335a8704f0c19472fde26ade8a7b9
Cr-Commit-Position: refs/heads/master@{#380312}

[brucedawson, 2016-03-09 22:15:24]

brucedawson@chromium.org changed reviewers:
+ dpranke@chromium.org, scottmg@chromium.org

[brucedawson, 2016-03-09 22:15:24]

Either of you want to weigh in on or approve this change?

I'm not thrilled about globally suppressing warnings, in general, so I've filed
a bug to track improving that in the future.

They are new warnings however, and initial suppression seems like a reasonable
strategy for that.

I'm still testing (try job is running on
https://codereview.chromium.org/1779713003/ and I'm doing local builds). The
issues I'm seeing are that 64-bit debug builds of some components hit ILK limits
on one machine, and
"native_client\toolchain\win_x86\pnacl_newlib\bin\le32-nacl-ld.gold.exe: out of
memory" errors on another. I'm not sure how well 64-bit debug builds are
supposed to work.

[Dirk Pranke, 2016-03-09 23:41:32]

lgtm . I'm fine w/ land now, triage new warnings later.

[brucedawson, 2016-03-09 23:42:36]

Ping! Any thoughts/approvals?

I found Scott's bug for the le32-nacl-ld.gold.exe: out of memory failures
so I know those aren't an issue. I'm investigating the ILK limits on GYP
builds but those are unrelated to this change.

[brucedawson, 2016-03-09 23:43:08]

On 2016/03/09 23:42:36, brucedawson wrote:
> Ping! Any thoughts/approvals?
> 
> I found Scott's bug for the le32-nacl-ld.gold.exe: out of memory failures
> so I know those aren't an issue. I'm investigating the ILK limits on GYP
> builds but those are unrelated to this change.

Ah, cool. Our messages crossed in the ether.

[brucedawson, 2016-03-09 23:43:25]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-03-09 23:43:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1781593004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1781593004/1

[commit-bot: I haz the power, 2016-03-10 02:28:57]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-10 02:30:02]

Description was changed from

==========
Suppress new C4334 and C4595 warnings

These two warnings are new in VS 2015 Update 2 (C4334 isn't necessarily
brand new, but it fires much more frequently now). Therefore they are
preventing a switch to VS 2015, without actually indicating any new
issues. The possible issues pointed to by C4334, in particular, have
been benign in every case that I have investigated. Therefore the
pragmatic thing to do is to suppress them for now, and resolve the
warnings individually after VS 2015 is the default.

The 4595 warning suppression is only needed in third_party\icu but it is
placed globally temporarily.

These warnings are also blocking PGO builds - another reason why a
timely fix is important.

BUG=440500,593448,591920
==========

to

==========
Suppress new C4334 and C4595 warnings

These two warnings are new in VS 2015 Update 2 (C4334 isn't necessarily
brand new, but it fires much more frequently now). Therefore they are
preventing a switch to VS 2015, without actually indicating any new
issues. The possible issues pointed to by C4334, in particular, have
been benign in every case that I have investigated. Therefore the
pragmatic thing to do is to suppress them for now, and resolve the
warnings individually after VS 2015 is the default.

The 4595 warning suppression is only needed in third_party\icu but it is
placed globally temporarily.

These warnings are also blocking PGO builds - another reason why a
timely fix is important.

BUG=440500,593448,591920

Committed: https://crrev.com/58552f9fcee335a8704f0c19472fde26ade8a7b9
Cr-Commit-Position: refs/heads/master@{#380312}
==========

[commit-bot: I haz the power, 2016-03-10 02:30:02]

Patchset 1 (id:??) landed as
https://crrev.com/58552f9fcee335a8704f0c19472fde26ade8a7b9
Cr-Commit-Position: refs/heads/master@{#380312}