Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 1781573004: Mojo C++ bindings: error notification behavior related to sync calls. (Closed)

Created:
4 years, 9 months ago by yzshen1
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: error notification behavior related to sync calls. This CL changes the behavior to: - connection error handler doesn't reenter ongoing sync calls. - connection error handler is delayed until all queued asynchronous messages are processed. BUG=577699 Committed: https://crrev.com/6f89b17073a5e29aa6fd29ab16ad0ac679d2088d Cr-Commit-Position: refs/heads/master@{#380259}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -10 lines) Patch
M mojo/public/cpp/bindings/lib/connector.cc View 1 chunk +9 lines, -7 lines 0 comments Download
M mojo/public/cpp/bindings/lib/router.h View 3 chunks +6 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/lib/router.cc View 3 chunks +23 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/sync_method_unittest.cc View 1 chunk +114 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
yzshen1
Hi, Scott. Would you please take a look? Thanks!
4 years, 9 months ago (2016-03-09 21:17:51 UTC) #2
sky
LGTM
4 years, 9 months ago (2016-03-09 22:27:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781573004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781573004/20001
4 years, 9 months ago (2016-03-09 22:32:13 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-09 23:38:20 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 23:41:37 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6f89b17073a5e29aa6fd29ab16ad0ac679d2088d
Cr-Commit-Position: refs/heads/master@{#380259}

Powered by Google App Engine
This is Rietveld 408576698