Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1781573003: Expose Array.prototype.values behind a flag and stage it (Closed)

Created:
4 years, 9 months ago by adamk
Modified:
4 years, 9 months ago
Reviewers:
Dan Ehrenberg
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Expose Array.prototype.values behind a flag and stage it BUG=v8:4247 LOG=y Committed: https://crrev.com/c48c1736c7d4af28f206f93d049a55eccc4ee574 Cr-Commit-Position: refs/heads/master@{#34640}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -12 lines) Patch
M src/bootstrapper.cc View 2 chunks +21 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/es6/array-prototype-values.js View 1 chunk +15 lines, -0 lines 0 comments Download
M test/test262/test262.status View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
adamk
4 years, 9 months ago (2016-03-09 20:58:33 UTC) #2
Dan Ehrenberg
lgtm
4 years, 9 months ago (2016-03-09 22:21:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781573003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781573003/1
4 years, 9 months ago (2016-03-09 22:25:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 22:27:37 UTC) #6
Dan Ehrenberg
lgtm
4 years, 9 months ago (2016-03-09 22:34:12 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 22:47:18 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c48c1736c7d4af28f206f93d049a55eccc4ee574
Cr-Commit-Position: refs/heads/master@{#34640}

Powered by Google App Engine
This is Rietveld 408576698