Track USBDevice open state in Blink.

Track USBDevice open state in Blink.

This change is the first in a series of patches that add logic to track
aspects of device state such as whether it is open and what
configuration has been selected in Blink in addition to whatever
validation occurs in the browser. The reasons for this are two-fold:

 1) It makes generating useful error messages easier because detailed
    error information does not need to be transmitted over IPC.
 2) It allows the WebUSB API to provide attributes such as ".opened" and
    ".selected" on the device, configurations and interfaces.

BUG=593164
Committed: https://crrev.com/3a80f8993c32aefb757e8e2ff5e1fcff3a9dbc32
Cr-Commit-Position: refs/heads/master@{#380315}

[Reilly Grant (use Gerrit), 2016-03-08 23:45:13]

reillyg@chromium.org changed reviewers:
+ juncai@chromium.org

[Reilly Grant (use Gerrit), 2016-03-08 23:45:14]

Please take a look.

[juncai, 2016-03-09 19:33:51]

LGTM with nits.

https://codereview.chromium.org/1781533002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webusb/USBDevice.cpp (right):

https://codereview.chromium.org/1781533002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webusb/USBDevice.cpp:110: bool m_desiredState;
nit: can add some comment about this variable, since it is used by setOpened().
For example, true/false means the desired state is opened/closed.

https://codereview.chromium.org/1781533002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webusb/USBDevice.cpp:261: m_device->open(new
OpenClosePromiseAdapter(this, resolver, true));
nit: add comments about the true parameter passed to this function.

https://codereview.chromium.org/1781533002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webusb/USBDevice.cpp:270: if
(m_openStateChangeInProgress) {
nit: does it make sense to rename this variable to be:
m_openCloseStateChangeInProgress? Since it is used by both open() and close()
functions?

https://codereview.chromium.org/1781533002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webusb/USBDevice.cpp:276: m_device->close(new
OpenClosePromiseAdapter(this, resolver, false));
nit: same here for the false parameter.

[Reilly Grant (use Gerrit), 2016-03-10 00:27:49]

https://codereview.chromium.org/1781533002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webusb/USBDevice.cpp (right):

https://codereview.chromium.org/1781533002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webusb/USBDevice.cpp:110: bool m_desiredState;
On 2016/03/09 at 19:33:51, juncai wrote:
> nit: can add some comment about this variable, since it is used by
setOpened(). For example, true/false means the desired state is opened/closed.

Done.

https://codereview.chromium.org/1781533002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webusb/USBDevice.cpp:261: m_device->open(new
OpenClosePromiseAdapter(this, resolver, true));
On 2016/03/09 at 19:33:50, juncai wrote:
> nit: add comments about the true parameter passed to this function.

Done.

https://codereview.chromium.org/1781533002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webusb/USBDevice.cpp:270: if
(m_openStateChangeInProgress) {
On 2016/03/09 at 19:33:51, juncai wrote:
> nit: does it make sense to rename this variable to be:
> m_openCloseStateChangeInProgress? Since it is used by both open() and close()
functions?

In my next patch I decided to change it to m_deviceStateChangeInProgress and so
have backported that change here.

https://codereview.chromium.org/1781533002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webusb/USBDevice.cpp:276: m_device->close(new
OpenClosePromiseAdapter(this, resolver, false));
On 2016/03/09 at 19:33:51, juncai wrote:
> nit: same here for the false parameter.

Done.

[Reilly Grant (use Gerrit), 2016-03-10 00:31:37]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2016-03-10 00:31:37]

The patchset sent to the CQ was uploaded after l-g-t-m from juncai@chromium.org
Link to the patchset: https://codereview.chromium.org/1781533002/#ps40001
(title: "Addressed juncai@'s nits.")

[commit-bot: I haz the power, 2016-03-10 00:32:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1781533002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1781533002/40001

[commit-bot: I haz the power, 2016-03-10 00:35:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 00:35:27]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Reilly Grant (use Gerrit), 2016-03-10 01:01:53]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2016-03-10 01:01:54]

The patchset sent to the CQ was uploaded after l-g-t-m from juncai@chromium.org
Link to the patchset: https://codereview.chromium.org/1781533002/#ps60001
(title: "Rebased.")

[commit-bot: I haz the power, 2016-03-10 01:02:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1781533002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1781533002/60001

[commit-bot: I haz the power, 2016-03-10 02:52:15]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-10 02:53:37]

Description was changed from

==========
Track USBDevice open state in Blink.

This change is the first in a series of patches that add logic to track
aspects of device state such as whether it is open and what
configuration has been selected in Blink in addition to whatever
validation occurs in the browser. The reasons for this are two-fold:

 1) It makes generating useful error messages easier because detailed
    error information does not need to be transmitted over IPC.
 2) It allows the WebUSB API to provide attributes such as ".opened" and
    ".selected" on the device, configurations and interfaces.

BUG=593164
==========

to

==========
Track USBDevice open state in Blink.

This change is the first in a series of patches that add logic to track
aspects of device state such as whether it is open and what
configuration has been selected in Blink in addition to whatever
validation occurs in the browser. The reasons for this are two-fold:

 1) It makes generating useful error messages easier because detailed
    error information does not need to be transmitted over IPC.
 2) It allows the WebUSB API to provide attributes such as ".opened" and
    ".selected" on the device, configurations and interfaces.

BUG=593164

Committed: https://crrev.com/3a80f8993c32aefb757e8e2ff5e1fcff3a9dbc32
Cr-Commit-Position: refs/heads/master@{#380315}
==========

[commit-bot: I haz the power, 2016-03-10 02:53:38]

Patchset 4 (id:??) landed as
https://crrev.com/3a80f8993c32aefb757e8e2ff5e1fcff3a9dbc32
Cr-Commit-Position: refs/heads/master@{#380315}