content/renderer/media/webrtc_audio_device_impl.cc - Issue 178153007: Avoid hitting the thread check when WebRtcAudioRenderer is going away.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc_audio_device_impl.cc

Issue 178153007: Avoid hitting the thread check when WebRtcAudioRenderer is going away. (Closed) Base URL: http://git.chromium.org/chromium/src.git@libjingle_get_stats

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/webrtc_audio_device_impl.h ('K') | « content/renderer/media/webrtc_audio_device_impl.h ('k') | content/renderer/media/webrtc_audio_renderer.cc » ('j') | content/renderer/media/webrtc_audio_renderer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc_audio_device_impl.cc

diff --git a/content/renderer/media/webrtc_audio_device_impl.cc b/content/renderer/media/webrtc_audio_device_impl.cc

index ef816fcc60d359c2f150be6fb5ce8cead0108686..5722a1beb546abd76f9bba4d0b1ea0fa850ea13f 100644

--- a/content/renderer/media/webrtc_audio_device_impl.cc

+++ b/content/renderer/media/webrtc_audio_device_impl.cc

@@ -175,6 +175,12 @@ void WebRtcAudioDeviceImpl::RemoveAudioRenderer(WebRtcAudioRenderer* renderer) {

DCHECK(thread_checker_.CalledOnValidThread());

DCHECK_EQ(renderer, renderer_);

base::AutoLock auto_lock(lock_);

+ // Notify the playout sink on the change.

tommi (sloooow) - chröme 2014/03/04 20:48:39 s/on/of

no longer working on chromium 2014/03/05 13:01:04 Done.

+ for (PlayoutDataSinkList::const_iterator it = playout_sinks_.begin();

+ it != playout_sinks_.end(); ++it) {

tommi (sloooow) - chröme 2014/03/04 20:48:39 indent

no longer working on chromium 2014/03/05 13:01:04 Done.

+ (*it)->OnPlayoutDataSourceChanged();

+ }

renderer_ = NULL;

playing_ = false;

}