src/wasm/decoder.h - Issue 1781523002: [wasm] All strings are length-prefixed and inline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/wasm/decoder.h

Issue 1781523002: [wasm] All strings are length-prefixed and inline (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: comment Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/wasm/decoder.h

diff --git a/src/wasm/decoder.h b/src/wasm/decoder.h

index 0ca4e47f7525f059820ddc73eb017e821cbce8a9..098c3306da05b0f750a1cc4fb043277b852777d1 100644

--- a/src/wasm/decoder.h

+++ b/src/wasm/decoder.h

@@ -225,6 +225,8 @@ class Decoder {

*length = static_cast<int>(pc_ - pos);

if (pc_ == end && (b & 0x80)) {

error(pc_ - 1, "varint too large");

+ } else if (*length == 0) {

+ error(pc_, "varint of length 0");

} else {

TRACE("= %u\n", result);

}

« no previous file with comments | « src/compiler/wasm-compiler.cc ('k') | src/wasm/encoder.cc » ('j') | no next file with comments »