Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1781473002: Fix incremental build of analyzer snapshot when pkg/analyzer changes. (Closed)

Created:
4 years, 9 months ago by Paul Berry
Modified:
4 years, 9 months ago
Reviewers:
pquitslund, scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix incremental build of analyzer snapshot when pkg/analyzer changes. Previously, changing a file in pkg/analyzer would not force a rebuild of the analyzer snapshot, causing confusion during anayzer development. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/1fa1b388c13cee800be1d5d5abb103a837a38a3c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M utils/dartanalyzer/dartanalyzer.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 9 months ago (2016-03-08 20:48:27 UTC) #2
scheglov
LGTM
4 years, 9 months ago (2016-03-08 20:50:04 UTC) #3
Paul Berry
4 years, 9 months ago (2016-03-08 22:04:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1fa1b388c13cee800be1d5d5abb103a837a38a3c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698