Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1781463002: Fix table background painting (Closed)

Created:
4 years, 9 months ago by atotic
Modified:
3 years, 11 months ago
Reviewers:
Xianzhu
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, slimming-paint-reviews_chromium.org, dshwang, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix table background painting Implement TableCollapsedBorderPainter BUG=125336 BUG=2902

Patch Set 1 #

Patch Set 2 : fix test cases #

Patch Set 3 : Demonstration of TableCollapsedBorderPainter #

Patch Set 4 : Sample code for improved collapsed border painting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1807 lines, -14 lines) Patch
M third_party/WebKit/LayoutTests/fast/repaint/table-col-background.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/table-col-background-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.cpp View 1 2 2 chunks +26 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCol.h View 1 2 2 chunks +18 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCol.cpp View 1 2 4 chunks +142 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableRow.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableRow.cpp View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.h View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.cpp View 1 2 2 chunks +51 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/TableCellPainter.h View 1 2 3 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/TableCellPainter.cpp View 1 2 4 chunks +105 lines, -1 line 0 comments Download
A third_party/WebKit/Source/core/paint/TableCollapsedBorderPainter.h View 1 2 1 chunk +196 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/paint/TableCollapsedBorderPainter.cpp View 1 2 1 chunk +1187 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TablePainter.cpp View 1 2 2 chunks +17 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableSectionPainter.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableSectionPainter.cpp View 3 chunks +24 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781463002/1
4 years, 9 months ago (2016-03-08 19:50:29 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 20:06:24 UTC) #4 
Dry run: Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

Powered by Google App Engine
This is Rietveld 408576698