Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1781393002: [turbofan] Fix operand calculation for constant materialization from frame. (Closed)

Created:
4 years, 9 months ago by Jarin
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, Benedikt Meurer, Michael Starzinger
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix operand calculation for constant materialization from frame. BUG=chromium:593299 LOG=N Committed: https://crrev.com/4d4bd54f0ad06fc92b8df2d787ec127e80e3dff9 Cr-Commit-Position: refs/heads/master@{#34736}

Patch Set 1 #

Patch Set 2 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -69 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M src/compiler/code-generator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/code-generator.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 2 chunks +9 lines, -12 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M src/compiler/s390/code-generator-s390.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M src/compiler/x87/code-generator-x87.cc View 2 chunks +9 lines, -12 lines 0 comments Download
A + test/mjsunit/regress/regress-593299.js View 1 1 chunk +11 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Jarin
Could you take a look, please?
4 years, 9 months ago (2016-03-11 14:36:14 UTC) #2
Igor Sheludko
lgtm
4 years, 9 months ago (2016-03-11 16:10:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781393002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781393002/40001
4 years, 9 months ago (2016-03-13 19:54:26 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 9 months ago (2016-03-13 20:21:00 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/4d4bd54f0ad06fc92b8df2d787ec127e80e3dff9 Cr-Commit-Position: refs/heads/master@{#34736}
4 years, 9 months ago (2016-03-13 20:21:53 UTC) #9
Michael Achenbach
CC mtrofin for the greedy allocator breakage: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug%20-%20greedy%20allocator/builds/5041
4 years, 9 months ago (2016-03-14 07:00:20 UTC) #12
Mircea Trofin
4 years, 9 months ago (2016-03-14 16:21:06 UTC) #13
Message was sent while issue was closed.
On 2016/03/14 07:00:20, Michael Achenbach wrote:
> CC mtrofin for the greedy allocator breakage:
>
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug%20-%...

https://codereview.chromium.org/1799113003/ fixes that breakage.

Powered by Google App Engine
This is Rietveld 408576698