Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1781273009: Space out issuing of spellcheck requests to speed up layout test. (Closed)

Created:
4 years, 9 months ago by sof
Modified:
4 years, 9 months ago
Reviewers:
haraken, yosin_UTC9
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Space out issuing of spellcheck requests to speed up layout test. Avoid issuing all spellcheck requests (by focusing elements) in one go as this queues up a number of tasks and timers that it will require going back to the event loop many times to process and handle. As the actual test also relies on timers and setTimeout() this delays the completion of the test considerably. Restructure the test, interleaving the element focusing (=> spellcheck request) with asynchronously checking the spellcheck result. Test completes earlier as a result. R=haraken BUG=356957 TEST=editing/spelling/spellcheck-editable-on-focus.html Committed: https://crrev.com/7acaf8fd9fb9680ba4ba0956f289d43c4f6ef647 Cr-Commit-Position: refs/heads/master@{#380895}

Patch Set 1 #

Patch Set 2 : force layout tests to run.... #

Patch Set 3 : undo test-triggering change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -26 lines) Patch
M third_party/WebKit/LayoutTests/editing/spelling/spellcheck-editable-on-focus.html View 3 chunks +20 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/spellcheck-editable-on-focus-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
sof
please take a look. just fixing a slow-running test; mac_blink_dbg reports the test runs in ...
4 years, 9 months ago (2016-03-12 17:32:32 UTC) #2
haraken
LGTM
4 years, 9 months ago (2016-03-12 23:57:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781273009/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781273009/40001
4 years, 9 months ago (2016-03-13 07:29:27 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-13 08:22:09 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-13 08:23:29 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7acaf8fd9fb9680ba4ba0956f289d43c4f6ef647
Cr-Commit-Position: refs/heads/master@{#380895}

Powered by Google App Engine
This is Rietveld 408576698