headless: Make it possible to configure an HTTP proxy

headless/lib/browser/headless_web_contents_impl.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "headless/lib/browser/headless_web_contents_impl.h"
 
 #include "base/bind.h"
 #include "base/memory/weak_ptr.h"
 #include "base/trace_event/trace_event.h"
+#include "content/public/browser/navigation_handle.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_delegate.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "content/public/common/bindings_policy.h"
 #include "content/public/common/service_registry.h"
 #include "content/public/renderer/render_frame.h"
 #include "ui/aura/window.h"
 
 namespace headless {
 
 class WebContentsObserverAdapter : public content::WebContentsObserver {
  public:
   WebContentsObserverAdapter(content::WebContents* web_contents,
                              HeadlessWebContents::Observer* observer)
       : content::WebContentsObserver(web_contents), observer_(observer) {}
 
   ~WebContentsObserverAdapter() override {}
 
   void DocumentOnLoadCompletedInMainFrame() override {
     observer_->DocumentOnLoadCompletedInMainFrame();
   }
 
+  void DidFinishNavigation(
+      content::NavigationHandle* navigation_handle) override {
+    observer_->DidFinishNavigation(navigation_handle->HasCommitted() &&
+                                   !navigation_handle->IsErrorPage());

[alex clarke (OOO till 29th), 2016/03/14 18:16:08]

Will the observer ever care about errors?

[Sami, 2016/03/14 18:33:27]

They definitely will, but for now I wanted to keep this interface as simple and
dumb as possible since we are going to replace it with the client API. I just
need this boolean bit for now to make the tests useful.

+  }
+
  private:
   HeadlessWebContents::Observer* observer_;  // Not owned.
 
   DISALLOW_COPY_AND_ASSIGN(WebContentsObserverAdapter);
 };
 
 class HeadlessWebContentsImpl::Delegate : public content::WebContentsDelegate {
  public:
   Delegate() {}
 
@@ skipping 49 matching lines @@
   ObserverMap::iterator it = observer_map_.find(observer);
   DCHECK(it != observer_map_.end());
   observer_map_.erase(it);
 }
 
 content::WebContents* HeadlessWebContentsImpl::web_contents() const {
   return web_contents_.get();
 }
 
 }  // namespace headless