Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1634)

Unified Diff: remoting/protocol/pairing_authenticator_base.h

Issue 1781173005: Handle pairing_client_id in the negotiating authenticators. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@config
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/protocol/pairing_authenticator_base.h
diff --git a/remoting/protocol/pairing_authenticator_base.h b/remoting/protocol/pairing_authenticator_base.h
index 14645c142776d56394041d8a3138a44fde090a7a..1b3104ea815c00142fa19f633cd15e4c92325acb 100644
--- a/remoting/protocol/pairing_authenticator_base.h
+++ b/remoting/protocol/pairing_authenticator_base.h
@@ -53,19 +53,12 @@ class PairingAuthenticatorBase : public Authenticator {
scoped_ptr<ChannelAuthenticator> CreateChannelAuthenticator() const override;
protected:
- static const buzz::StaticQName kPairingInfoTag;
- static const buzz::StaticQName kClientIdAttribute;
-
// Create a Spake2 authenticator in the specified state, prompting the user
// for the PIN first if necessary.
virtual void CreateSpakeAuthenticatorWithPin(
State initial_state,
const base::Closure& resume_callback) = 0;
- // Amend an authenticator message, for example to add client- or host-specific
- // elements to it.
- virtual void AddPairingElements(buzz::XmlElement* message) = 0;
-
// A non-fatal error message that derived classes should set in order to
// cause the peer to be notified that pairing has failed and that it should
// fall back on PIN authentication. This string need not be human-readable,
@@ -81,7 +74,7 @@ class PairingAuthenticatorBase : public Authenticator {
bool using_paired_secret_ = false;
private:
- // Helper methods for ProcessMessage and GetNextMessage
+ // Helper methods for ProcessMessage() and GetNextMessage().
void MaybeAddErrorMessage(buzz::XmlElement* message);
bool HasErrorMessage(const buzz::XmlElement* message) const;
void CheckForFailedSpakeExchange(const base::Closure& resume_callback);
« no previous file with comments | « remoting/protocol/negotiating_host_authenticator.cc ('k') | remoting/protocol/pairing_authenticator_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698