Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 1781123004: Filter warnings from dependency_overrides to make travis green on (Closed)

Created:
4 years, 9 months ago by Leaf
Modified:
4 years, 9 months ago
Reviewers:
vsm, Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Filter warnings from dependency_overrides to make travis green on bleeding edge analyzer. Bleeding edge analyzer has some deprecation hints. We're using --package-warnings in our analyze.sh script and grepping for dev_compiler directory to limit us to dev_compiler errors. This CL adds an additional filter to hide warnings from dependency_overrides. BUG= R=jmesserly@google.com, vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/6e6f413febb1809ce4c9692d638104ce475ec9e9

Patch Set 1 #

Patch Set 2 : Use tmp dir #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tool/dependency_overrides.sh View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
Leaf
4 years, 9 months ago (2016-03-12 01:07:26 UTC) #3
Jennifer Messerly
lgtm. Out of curiosity do you know where dependency_overrides stuff comes from?
4 years, 9 months ago (2016-03-12 01:09:03 UTC) #4
Jennifer Messerly
On 2016/03/12 01:09:03, John Messerly wrote: > lgtm. Out of curiosity do you know where ...
4 years, 9 months ago (2016-03-12 01:09:45 UTC) #5
Leaf
On 2016/03/12 01:09:45, John Messerly wrote: > On 2016/03/12 01:09:03, John Messerly wrote: > > ...
4 years, 9 months ago (2016-03-12 01:15:54 UTC) #6
vsm
lgtm, but a little cleaner to checkout out to a tmp dir if possible
4 years, 9 months ago (2016-03-14 13:17:28 UTC) #7
Leaf
Ok, using tmp dir now, PTAL. Still failing on travis, but now because of actual ...
4 years, 9 months ago (2016-03-14 20:46:40 UTC) #8
vsm
lgtm
4 years, 9 months ago (2016-03-14 20:48:31 UTC) #9
Leaf
4 years, 9 months ago (2016-03-14 21:53:01 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
6e6f413febb1809ce4c9692d638104ce475ec9e9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698