Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1781123002: Landing Recent QUIC changes until 2016-03-07 19:39 UTC (Closed)

Created:
4 years, 9 months ago by rjshade
Modified:
4 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Landing Recent QUIC changes until 2016-03-07 19:39 UTC Up to, and including internal change 116570346 Add a new QUIC Ack Decimation mode that is reordering tolerant. Protected by FLAG_quic_ack_decimation2. Merge internal change: 115853846 https://codereview.chromium.org/1777293002/ Deprecating FLAG_quic_batch_writes Merge internal change: 115880164 https://codereview.chromium.org/1780913002/ Deprecate FLAG_quic_validate_stk_without_scid Merge internal change: 115885351 https://codereview.chromium.org/1780923002/ Deprecate FLAG_quic_use_new_tcp_sender Merge internal change: 115890504 https://codereview.chromium.org/1785663003/ Deprecate FLAG_quic_use_new_idle_timeout Merge internal change: 115904466 https://codereview.chromium.org/1785693003/ Deprecate FLAG_quic_block_unencrypted_writes Merge internal change: 115909446 https://codereview.chromium.org/1784643006/ Clang formatting net/quic. Merge internal change: 115992556 https://codereview.chromium.org/1780783003/ Optionally defer responding to a QUIC ACK until all ACK processing has completed for an EpollServer iteration. Guarded by FLAG_quic_connection_defer_ack_response Merge internal change: 114770052 https://codereview.chromium.org/1782053003/ Deprecate FLAG_require_strike_register_or_server_nonce Merge internal change: 115891009 https://codereview.chromium.org/1785613005/ Add a boolean use_stateless_rejects_if_peer_supported argument to the QuicCryptoServerStream constructor instead of consulting FLAG_enable_quic_stateless_reject_support directly. No behavior change expected. Merge internal change: 115844136 https://codereview.chromium.org/1783713003/ Remove FEC from send path. Merge internal change: 115997404 https://codereview.chromium.org/1784903003/ Remove FEC code from receive path. Drop received FEC packet. Merge internal change: 116134765 https://codereview.chromium.org/1782143003/ Only cancel QUIC alarms if they have been set. Protected behind FLAG_quic_only_cancel_set_alarms Merge internal change: 116142833 https://codereview.chromium.org/1781073002/ Call QuicAlarm::IsSet instead of looking at deadline_ directly, rename some variables for readability. Merge internal change: 116146641 https://codereview.chromium.org/1778243005/ Add whether QUIC's unencrypted stream data was received or about to be sent in the error log. Logging only change. Merge internal change: 116152506 https://codereview.chromium.org/1782193002/ Temporarily store the raw QUIC packet in QuicConnection. Merge internal change: 116180343 https://codereview.chromium.org/1779313002/ Deprecate FLAG_quic_no_unencrypted_fec. Merge internal change: 116244697 https://codereview.chromium.org/1780573006/ Make ShouldCreateOutgoingDynamicStream a virtual method. Merge internal change: 116249386 https://codereview.chromium.org/1784933003/ Correctly handle EINTR during sendmsg in QuicSocketUtils::WritePacket. Merge internal change: 116261116 https://codereview.chromium.org/1780323002/ Simplify QUIC's encryption path now that FEC is gone. Protected by FLAG_quic_inplace_encryption. Merge internal change: 116266391 https://codereview.chromium.org/1785513003/ Remove the force param from QuicPacketGenerator::SetMaxPacketLength because path MTU packets should not be sent if the MTU cannot be changed. Not flag protected. Merge internal change: 116273065 https://codereview.chromium.org/1781043004/ Remove lastest_revived_packet from QuicAckFrame since FEC is gone. No functional change expected. Wire format is not changed yet. Merge internal change: 116411121 https://codereview.chromium.org/1787443002/ Remove is_fec_packet from TransmissionInfo and SerializedPacket. No functional change. Merge internal change: 116555910 https://codereview.chromium.org/1785853002/ Remove FEC related connection options and update FEC related comment in code base. Merge internal change: 116566297 https://codereview.chromium.org/1785863002/ Switch "const StringPiece&" to just "StringPiece" in QUIC code. No functional change. Not flag protected. Merge internal change: 116570346 https://codereview.chromium.org/1787453002/ Add a QuicCompressedCertsCache instance to QuicDispatcher, plumbing to QuicServerSessionBase but not used. No behavior change. Merge internal change: 116277134 https://codereview.chromium.org/1783783003/ Add more detailed logging to QUIC's ack validation. No functional change. Merge internal change: 116277228 https://codereview.chromium.org/1784963002/ Remove max_packet_length from QuicPacketGenerator, because it is no longer necessary with FEC gone. Not flag protected. Merge internal change: 116387934 https://codereview.chromium.org/1777423002/ Add QuicCompressedCertsCache* to QuicCrytoServerStream plumbed from QuicServerSessionBase. No behavior change. Merge internal change: 116388439 https://codereview.chromium.org/1782743005/ Remove unused return value from QuicAlarm::Delegate::OnAlarm. No behavior change, not protected. The only place in the codebase that returns something other than QuicTime::Zero() is the DelayAlarm in PacketDroppingTestWriter. I've the implementation of OnAlarm in there to set the alarm directly to the new time, rather than relying on the return value. Merge internal change: 116389752 https://codereview.chromium.org/1779883005/ Add a QUIC ScopedPacketBundler to send an ack when the ack alarm goes off. No functional change. Not flag protected. Merge internal change: 116391846 https://codereview.chromium.org/1786493003/ OnStreamEnd is now called instead of the sentinel call of OnStreamFrameData(stream_id, nullptr, 0, true). Protected by the flag FLAGS_spdy_on_stream_end. Merge internal change: 116272960 https://codereview.chromium.org/1777163003/ R=rch@chromium.org BUG= Committed: https://crrev.com/d069aaee0b3affb6004d8cf3a276c32e248a2a3d Cr-Commit-Position: refs/heads/master@{#380718}

Patch Set 1 #

Patch Set 2 : Remove "const StringPiece&" from Chromium _nss crypto files. #

Patch Set 3 : Update base signature to remove const StringPiece& #

Patch Set 4 : Fix signature of chacha override #

Patch Set 5 : Fix chacha nss implementation signature #

Patch Set 6 : Implement BufferedSpdyFramer::OnStreamEnd #

Patch Set 7 : Synced with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1657 lines, -8169 lines) Patch
M net/net.gypi View 2 chunks +0 lines, -6 lines 0 comments Download
M net/quic/congestion_control/pacing_sender_test.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/quic/congestion_control/send_algorithm_interface.cc View 2 chunks +7 lines, -29 lines 0 comments Download
D net/quic/congestion_control/tcp_cubic_bytes_sender.h View 1 chunk +0 lines, -151 lines 0 comments Download
D net/quic/congestion_control/tcp_cubic_bytes_sender.cc View 1 chunk +0 lines, -390 lines 0 comments Download
D net/quic/congestion_control/tcp_cubic_bytes_sender_test.cc View 1 chunk +0 lines, -743 lines 0 comments Download
D net/quic/congestion_control/tcp_cubic_sender.h View 1 chunk +0 lines, -152 lines 0 comments Download
D net/quic/congestion_control/tcp_cubic_sender.cc View 1 chunk +0 lines, -401 lines 0 comments Download
D net/quic/congestion_control/tcp_cubic_sender_test.cc View 1 chunk +0 lines, -887 lines 0 comments Download
M net/quic/crypto/aead_base_decrypter.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/crypto/aead_base_decrypter_nss.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/crypto/aead_base_decrypter_openssl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/crypto/aes_128_gcm_12_decrypter.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/aes_128_gcm_12_decrypter_nss.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/chacha20_poly1305_decrypter.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/chacha20_poly1305_decrypter_nss.cc View 1 1 chunk +4 lines, -5 lines 0 comments Download
M net/quic/crypto/chacha20_poly1305_rfc7539_decrypter.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/chacha20_poly1305_rfc7539_decrypter_nss.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/crypto_protocol.h View 2 chunks +2 lines, -9 lines 0 comments Download
M net/quic/crypto/crypto_server_test.cc View 3 chunks +0 lines, -75 lines 0 comments Download
M net/quic/crypto/curve25519_key_exchange.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/crypto/curve25519_key_exchange.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M net/quic/crypto/key_exchange.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/null_decrypter.h View 2 chunks +3 lines, -4 lines 0 comments Download
M net/quic/crypto/null_decrypter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/crypto/p256_key_exchange.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/p256_key_exchange_nss.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/p256_key_exchange_openssl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/quic_crypto_server_config.cc View 3 chunks +14 lines, -45 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/crypto/quic_decrypter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_alarm.h View 3 chunks +5 lines, -6 lines 0 comments Download
M net/quic/quic_alarm.cc View 3 chunks +14 lines, -16 lines 0 comments Download
M net/quic/quic_alarm_test.cc View 3 chunks +3 lines, -15 lines 0 comments Download
M net/quic/quic_chromium_client_session_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_chromium_client_stream_test.cc View 6 chunks +5 lines, -7 lines 0 comments Download
M net/quic/quic_chromium_connection_helper_test.cc View 1 chunk +1 line, -4 lines 0 comments Download
M net/quic/quic_client_promised_info.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_client_promised_info.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/quic_config_test.cc View 4 chunks +2 lines, -9 lines 0 comments Download
M net/quic/quic_connection.h View 21 chunks +28 lines, -43 lines 0 comments Download
M net/quic/quic_connection.cc View 49 chunks +85 lines, -254 lines 0 comments Download
M net/quic/quic_connection_logger.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/quic_connection_logger.cc View 1 2 3 4 5 6 2 chunks +0 lines, -11 lines 0 comments Download
M net/quic/quic_connection_stats.h View 3 chunks +2 lines, -3 lines 0 comments Download
M net/quic/quic_connection_stats.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_connection_test.cc View 54 chunks +231 lines, -1188 lines 0 comments Download
M net/quic/quic_crypto_client_stream_test.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M net/quic/quic_crypto_server_stream.h View 4 chunks +7 lines, -1 line 0 comments Download
M net/quic/quic_crypto_server_stream.cc View 1 chunk +4 lines, -1 line 0 comments Download
M net/quic/quic_crypto_server_stream_test.cc View 4 chunks +10 lines, -9 lines 0 comments Download
M net/quic/quic_flags.h View 2 chunks +5 lines, -6 lines 0 comments Download
M net/quic/quic_flags.cc View 2 chunks +17 lines, -25 lines 0 comments Download
M net/quic/quic_framer.h View 10 chunks +14 lines, -32 lines 0 comments Download
M net/quic/quic_framer.cc View 15 chunks +35 lines, -117 lines 0 comments Download
M net/quic/quic_framer_test.cc View 59 chunks +63 lines, -403 lines 0 comments Download
M net/quic/quic_headers_stream.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_headers_stream_test.cc View 20 chunks +48 lines, -35 lines 0 comments Download
M net/quic/quic_multipath_received_packet_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/quic_multipath_received_packet_manager.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M net/quic/quic_multipath_received_packet_manager_test.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M net/quic/quic_packet_creator.h View 13 chunks +14 lines, -129 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 27 chunks +59 lines, -304 lines 0 comments Download
M net/quic/quic_packet_creator_test.cc View 34 chunks +53 lines, -583 lines 0 comments Download
M net/quic/quic_packet_generator.h View 8 chunks +5 lines, -53 lines 0 comments Download
M net/quic/quic_packet_generator.cc View 15 chunks +20 lines, -83 lines 0 comments Download
M net/quic/quic_packet_generator_test.cc View 39 chunks +65 lines, -922 lines 0 comments Download
M net/quic/quic_protocol.h View 9 chunks +8 lines, -39 lines 0 comments Download
M net/quic/quic_protocol.cc View 8 chunks +11 lines, -32 lines 0 comments Download
M net/quic/quic_received_packet_manager.h View 2 chunks +3 lines, -2 lines 0 comments Download
M net/quic/quic_received_packet_manager.cc View 3 chunks +4 lines, -15 lines 0 comments Download
M net/quic/quic_received_packet_manager_test.cc View 2 chunks +0 lines, -55 lines 0 comments Download
M net/quic/quic_sent_packet_manager.h View 3 chunks +7 lines, -4 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 6 chunks +3 lines, -21 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 4 chunks +0 lines, -136 lines 0 comments Download
M net/quic/quic_session.h View 2 chunks +1 line, -5 lines 0 comments Download
M net/quic/quic_session.cc View 3 chunks +5 lines, -11 lines 0 comments Download
M net/quic/quic_session_test.cc View 4 chunks +12 lines, -25 lines 0 comments Download
M net/quic/quic_spdy_stream_test.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M net/quic/quic_unacked_packet_map.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_unacked_packet_map.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/quic_write_blocked_list.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_write_blocked_list_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/reliable_quic_stream.h View 4 chunks +1 line, -10 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 4 chunks +4 lines, -13 lines 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 18 chunks +38 lines, -129 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 1 chunk +4 lines, -1 line 0 comments Download
M net/quic/test_tools/mock_quic_dispatcher.cc View 1 chunk +1 line, -4 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.h View 4 chunks +3 lines, -7 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.cc View 4 chunks +3 lines, -15 lines 0 comments Download
M net/quic/test_tools/quic_packet_creator_peer.h View 2 chunks +0 lines, -13 lines 0 comments Download
M net/quic/test_tools/quic_packet_creator_peer.cc View 3 chunks +1 line, -49 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 10 chunks +15 lines, -23 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 9 chunks +28 lines, -20 lines 0 comments Download
M net/quic/test_tools/reliable_quic_stream_peer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/test_tools/reliable_quic_stream_peer.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M net/quic/test_tools/simple_quic_framer.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/test_tools/simple_quic_framer.cc View 6 chunks +0 lines, -13 lines 0 comments Download
M net/spdy/buffered_spdy_framer.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_framer.h View 1 chunk +5 lines, -0 lines 0 comments Download
M net/spdy/spdy_framer.cc View 4 chunks +14 lines, -4 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 21 chunks +321 lines, -20 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 10 chunks +51 lines, -104 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 5 chunks +8 lines, -3 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 5 chunks +5 lines, -19 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 11 chunks +54 lines, -32 lines 0 comments Download
M net/tools/quic/quic_epoll_connection_helper_test.cc View 1 chunk +1 line, -4 lines 0 comments Download
M net/tools/quic/quic_server_session_base.h View 6 chunks +13 lines, -4 lines 0 comments Download
M net/tools/quic/quic_server_session_base.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M net/tools/quic/quic_server_session_base_test.cc View 7 chunks +27 lines, -10 lines 0 comments Download
M net/tools/quic/quic_simple_server_session.h View 2 chunks +4 lines, -2 lines 0 comments Download
M net/tools/quic/quic_simple_server_session.cc View 1 chunk +12 lines, -4 lines 0 comments Download
M net/tools/quic/quic_simple_server_session_test.cc View 12 chunks +22 lines, -14 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream_test.cc View 16 chunks +29 lines, -21 lines 0 comments Download
M net/tools/quic/quic_socket_utils.cc View 1 chunk +4 lines, -1 line 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/tools/quic/test_tools/packet_dropping_test_writer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/packet_dropping_test_writer.cc View 3 chunks +11 lines, -3 lines 0 comments Download
M net/tools/quic/test_tools/quic_dispatcher_peer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_dispatcher_peer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.h View 2 chunks +0 lines, -6 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_server.h View 2 chunks +4 lines, -2 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_server.cc View 4 chunks +22 lines, -9 lines 0 comments Download

Messages

Total messages: 44 (22 generated)
rjshade
4 years, 9 months ago (2016-03-10 23:28:29 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781123002/1
4 years, 9 months ago (2016-03-10 23:30:18 UTC) #3
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started ...
4 years, 9 months ago (2016-03-10 23:30:22 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781123002/1
4 years, 9 months ago (2016-03-10 23:33:05 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/143431) ios_rel_device_ninja on ...
4 years, 9 months ago (2016-03-10 23:54:55 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781123002/20001
4 years, 9 months ago (2016-03-11 14:32:53 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/185279)
4 years, 9 months ago (2016-03-11 14:39:29 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781123002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781123002/40001
4 years, 9 months ago (2016-03-11 15:18:09 UTC) #15
Ryan Hamilton
lgtm, but I'd love to understand why OnStreamEnd works.
4 years, 9 months ago (2016-03-11 15:19:33 UTC) #16
rjshade
On 2016/03/11 15:19:33, Ryan Hamilton wrote: > lgtm, but I'd love to understand why OnStreamEnd ...
4 years, 9 months ago (2016-03-11 15:25:55 UTC) #17
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/3560)
4 years, 9 months ago (2016-03-11 15:27:58 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781123002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781123002/60001
4 years, 9 months ago (2016-03-11 15:29:29 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/143766) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 9 months ago (2016-03-11 15:35:30 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781123002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781123002/80001
4 years, 9 months ago (2016-03-11 15:39:41 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/143779)
4 years, 9 months ago (2016-03-11 16:32:02 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781123002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781123002/100001
4 years, 9 months ago (2016-03-11 16:53:43 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/129757)
4 years, 9 months ago (2016-03-11 18:33:42 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781123002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781123002/120001
4 years, 9 months ago (2016-03-11 18:46:38 UTC) #37
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/138842)
4 years, 9 months ago (2016-03-11 19:43:54 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781123002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781123002/120001
4 years, 9 months ago (2016-03-11 19:54:28 UTC) #41
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 9 months ago (2016-03-11 20:42:42 UTC) #42
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 20:43:56 UTC) #44
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/d069aaee0b3affb6004d8cf3a276c32e248a2a3d
Cr-Commit-Position: refs/heads/master@{#380718}

Powered by Google App Engine
This is Rietveld 408576698