Set HAVE_SEARCH_H so that pdfium/xfa builds with VS 2015

Set HAVE_SEARCH_H so that pdfium/xfa builds with VS 2015

Enabling of XFA-Forms in crrev.com/1775173002 broke VS 2015 builds
because of a conflict between the lfind declaration in libtiff\tiffiop.h
and the one that ships with VS 2015. Defining HAVE_SEARCH_H for VS 2015
builds fixes this problem

BUG=440500, 593996
R=thakis@chromium.org, tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/aed7b33e893b97f4734ab6fa87a220231a321c60

[brucedawson, 2016-03-11 01:45:24]

brucedawson@chromium.org changed reviewers:
+ thakis@chromium.org, tsepez@chromium.org

[brucedawson, 2016-03-11 01:45:24]

Does this look like a correct fix? It seems to work for VS 2015, and shouldn't
affect VS 2013.

[Nico, 2016-03-11 16:35:02]

Looks like a good approach to me.

https://codereview.chromium.org/1781043005/diff/1/third_party/libtiff/tiffconf.h
File third_party/libtiff/tiffconf.h (right):

https://codereview.chromium.org/1781043005/diff/1/third_party/libtiff/tiffcon...
third_party/libtiff/tiffconf.h:1: /* libtiff/tiffconf.h.  Generated by
configure.  */
This is a generated file -- I don't know if we rerun configure ever...ah, looks
like we have the "add patch files" approach:
https://pdfium.googlesource.com/pdfium/+/master/third_party/libtiff/0000-buil...
https://pdfium.googlesource.com/pdfium/+/master/third_party/libtiff/README.pd...

Can you add a .patch file for this and update the README file with a reference
to it?

[Tom Sepez, 2016-03-11 17:47:44]

This will be fine once the .patch and README are updated.  Thanks immensely for
doing this.

[brucedawson, 2016-03-11 18:59:37]

On 2016/03/11 17:47:44, Tom Sepez wrote:
> This will be fine once the .patch and README are updated.  Thanks immensely
for
> doing this.

Okay, I created a new patch file and updated README.pdfium. I could also update
the existing patch file but it wasn't clear how to do that.

The change to enable XFA was reverted to the breakage is actually temporarily
gone, but clearly we still want to land a fix. I recreated the build break in
order to verify that this fix still works.

PTAL.

[Tom Sepez, 2016-03-11 20:02:57]

Adding a new patch is preferred. LGTM.

[Nico, 2016-03-11 21:18:48]

lgtm 2

[brucedawson, 2016-03-11 21:35:49]

Description was changed from

==========
Set HAVE_SEARCH_H so that pdfium/xfa builds with VS 2015

Enabling of XFA-Forms in crrev.com/1775173002 broke VS 2015 builds
because of a conflict between the lfind declaration in libtiff\tiffiop.h
and the one that ships with VS 2015. Defining HAVE_SEARCH_H for VS 2015
builds fixes this problem

BUG=440500,593996
==========

to

==========
Set HAVE_SEARCH_H so that pdfium/xfa builds with VS 2015

Enabling of XFA-Forms in crrev.com/1775173002 broke VS 2015 builds
because of a conflict between the lfind declaration in libtiff\tiffiop.h
and the one that ships with VS 2015. Defining HAVE_SEARCH_H for VS 2015
builds fixes this problem

BUG=440500,593996
R=thakis@chromium.org, tsepez@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/aed7b33e893b97f4734ab6fa87a220231a32...
==========

[brucedawson, 2016-03-11 21:35:50]

Committed patchset #2 (id:20001) manually as
aed7b33e893b97f4734ab6fa87a220231a321c60 (presubmit successful).