Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1120)

Unified Diff: net/http/http_network_transaction_ssl_unittest.cc

Issue 1781003003: Implement referred Token Bindings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_network_transaction_ssl_unittest.cc
diff --git a/net/http/http_network_transaction_ssl_unittest.cc b/net/http/http_network_transaction_ssl_unittest.cc
index d856996e93176727d06bd1559e7ee344c6c93081..cabd7626d5d49dbd7d344d545700bb91a3173d99 100644
--- a/net/http/http_network_transaction_ssl_unittest.cc
+++ b/net/http/http_network_transaction_ssl_unittest.cc
@@ -172,16 +172,16 @@ TEST_F(HttpNetworkTransactionSSLTest, TokenBinding) {
mock_socket_factory_.AddSocketDataProvider(&data);
HttpNetworkSession session(session_params_);
- HttpNetworkTransaction trans(DEFAULT_PRIORITY, &session);
+ HttpNetworkTransaction trans1(DEFAULT_PRIORITY, &session);
TestCompletionCallback callback;
- int rv =
- callback.GetResult(trans.Start(GetRequestInfo("https://www.example.com/"),
- callback.callback(), BoundNetLog()));
+ int rv = callback.GetResult(
+ trans1.Start(GetRequestInfo("https://www.example.com/"),
+ callback.callback(), BoundNetLog()));
EXPECT_EQ(OK, rv);
HttpRequestHeaders headers1;
- ASSERT_TRUE(trans.GetFullRequestHeaders(&headers1));
+ ASSERT_TRUE(trans1.GetFullRequestHeaders(&headers1));
std::string token_binding_header1;
EXPECT_TRUE(headers1.GetHeader(HttpRequestHeaders::kTokenBinding,
&token_binding_header1));
@@ -191,14 +191,15 @@ TEST_F(HttpNetworkTransactionSSLTest, TokenBinding) {
mock_socket_factory_.AddSSLSocketDataProvider(&ssl_data);
StaticSocketDataProvider data2(mock_reads, arraysize(mock_reads), NULL, 0);
mock_socket_factory_.AddSocketDataProvider(&data2);
+ HttpNetworkTransaction trans2(DEFAULT_PRIORITY, &session);
- rv =
- callback.GetResult(trans.Start(GetRequestInfo("https://www.example.com/"),
- callback.callback(), BoundNetLog()));
+ rv = callback.GetResult(
+ trans2.Start(GetRequestInfo("https://www.example.com/"),
+ callback.callback(), BoundNetLog()));
EXPECT_EQ(OK, rv);
HttpRequestHeaders headers2;
- ASSERT_TRUE(trans.GetFullRequestHeaders(&headers2));
+ ASSERT_TRUE(trans2.GetFullRequestHeaders(&headers2));
std::string token_binding_header2;
EXPECT_TRUE(headers2.GetHeader(HttpRequestHeaders::kTokenBinding,
&token_binding_header2));

Powered by Google App Engine
This is Rietveld 408576698