Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: scripts/slave/recipe_modules/chromium_tests/api.py

Issue 1781003002: chromium_tests: pass paths to runit.py and runtest.py for src/testing/scripts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium_tests/api.py
diff --git a/scripts/slave/recipe_modules/chromium_tests/api.py b/scripts/slave/recipe_modules/chromium_tests/api.py
index 8459408c1139bc1a6bd0cda266d1d140babfeb13..eb10bc9b24ea64f25be239f45d957866b04e6049 100644
--- a/scripts/slave/recipe_modules/chromium_tests/api.py
+++ b/scripts/slave/recipe_modules/chromium_tests/api.py
@@ -800,9 +800,14 @@ class ChromiumTestsApi(recipe_api.RecipeApi):
if self.m.chromium.c.runtest_py.src_side:
args.append('--use-src-side-runtest-py')
- paths = {}
- for path in ('build', 'checkout'):
- paths[path] = self.m.path[path]
+ paths = {
+ # TODO(phajdan.jr): Remove build path, http://crbug.com/593420 .
iannucci 2016/03/10 17:54:32 maybe we should have another bug for this cleanup,
Paweł Hajdan Jr. 2016/03/10 17:56:18 No, it's just one CL in src, which will be tested
+ 'build': self.m.path['build'],
iannucci 2016/03/10 17:54:32 I thought this one doesn't work on swarming?
Paweł Hajdan Jr. 2016/03/10 17:56:18 Correct. However, I can't remove it before fixing
+ 'checkout': self.m.path['checkout'],
+ 'runit.py': self.package_repo_resource('scripts', 'tools', 'runit.py'),
+ 'runtest.py': self.package_repo_resource(
+ 'scripts', 'slave', 'runtest.py'),
+ }
args.extend(['--paths', self.m.json.input(paths)])
properties = {}

Powered by Google App Engine
This is Rietveld 408576698