Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: components/metrics/file_metrics_provider_unittest.cc

Issue 1780993002: Break global impact of PersistentHistogramAllocator into a separate class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor-hp
Patch Set: fixed bad formatting from upstream scoped_ptr change Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/setup/installer_metrics.cc ('k') | components/metrics/metrics_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/file_metrics_provider_unittest.cc
diff --git a/components/metrics/file_metrics_provider_unittest.cc b/components/metrics/file_metrics_provider_unittest.cc
index 425777fe29eb45af25e04702166a0ef8fec538a4..0949c2d3690a3aeb5460ab2aed4c0ca6749ea83e 100644
--- a/components/metrics/file_metrics_provider_unittest.cc
+++ b/components/metrics/file_metrics_provider_unittest.cc
@@ -103,9 +103,9 @@ TEST_F(FileMetricsProviderTest, AccessMetrics) {
{
// Get this first so it isn't created inside the persistent allocator.
- base::PersistentHistogramAllocator::GetCreateHistogramResultHistogram();
+ base::GlobalHistogramAllocator::GetCreateHistogramResultHistogram();
- base::PersistentHistogramAllocator::CreateGlobalAllocatorOnLocalMemory(
+ base::GlobalHistogramAllocator::CreateWithLocalMemory(
64 << 10, 0, kMetricsName);
base::HistogramBase* foo =
base::Histogram::FactoryGet("foo", 1, 100, 10, 0);
@@ -115,7 +115,7 @@ TEST_F(FileMetricsProviderTest, AccessMetrics) {
bar->Add(84);
scoped_ptr<base::PersistentHistogramAllocator> histogram_allocator =
- base::PersistentHistogramAllocator::ReleaseGlobalAllocatorForTesting();
+ base::GlobalHistogramAllocator::ReleaseForTesting();
base::PersistentMemoryAllocator* allocator =
histogram_allocator->memory_allocator();
base::File writer(metrics_file(),
« no previous file with comments | « chrome/installer/setup/installer_metrics.cc ('k') | components/metrics/metrics_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698