Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: net/quic/crypto/proof_verifier_chromium_test.cc

Issue 1780983002: Provide valid port on HPKP reports for QUIC connections (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Correct ordering of arguments in test Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/crypto/proof_verifier_chromium.cc ('k') | net/quic/quic_crypto_client_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/crypto/proof_verifier_chromium_test.cc
diff --git a/net/quic/crypto/proof_verifier_chromium_test.cc b/net/quic/crypto/proof_verifier_chromium_test.cc
index b2fbba99b4bee50fcfa7e93ed5b73ce8bd78523b..bc2d27ff64ed646ea231856f84dfb926ddc7e23e 100644
--- a/net/quic/crypto/proof_verifier_chromium_test.cc
+++ b/net/quic/crypto/proof_verifier_chromium_test.cc
@@ -101,6 +101,7 @@ class DummyProofVerifierCallback : public ProofVerifierCallback {
};
const char kTestHostname[] = "test.example.com";
+const uint16_t kTestPort = 8443;
const char kTestConfig[] = "server config bytes";
const char kLogDescription[] = "somelog";
@@ -222,7 +223,7 @@ TEST_F(ProofVerifierChromiumTest, FailsIfCertFails) {
scoped_ptr<DummyProofVerifierCallback> callback(
new DummyProofVerifierCallback);
QuicAsyncStatus status = proof_verifier.VerifyProof(
- kTestHostname, kTestConfig, QUIC_VERSION_25, "", certs_, "",
+ kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_25, "", certs_, "",
GetTestSignature(), verify_context_.get(), &error_details_, &details_,
callback.get());
ASSERT_EQ(QUIC_FAILURE, status);
@@ -240,7 +241,7 @@ TEST_F(ProofVerifierChromiumTest, ValidSCTList) {
scoped_ptr<DummyProofVerifierCallback> callback(
new DummyProofVerifierCallback);
QuicAsyncStatus status = proof_verifier.VerifyProof(
- kTestHostname, kTestConfig, QUIC_VERSION_25, "", certs_,
+ kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_25, "", certs_,
ct::GetSCTListForTesting(), "", verify_context_.get(), &error_details_,
&details_, callback.get());
ASSERT_EQ(QUIC_FAILURE, status);
@@ -259,7 +260,7 @@ TEST_F(ProofVerifierChromiumTest, InvalidSCTList) {
scoped_ptr<DummyProofVerifierCallback> callback(
new DummyProofVerifierCallback);
QuicAsyncStatus status = proof_verifier.VerifyProof(
- kTestHostname, kTestConfig, QUIC_VERSION_25, "", certs_,
+ kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_25, "", certs_,
ct::GetSCTListWithInvalidSCT(), "", verify_context_.get(),
&error_details_, &details_, callback.get());
ASSERT_EQ(QUIC_FAILURE, status);
@@ -276,8 +277,9 @@ TEST_F(ProofVerifierChromiumTest, FailsIfSignatureFails) {
scoped_ptr<DummyProofVerifierCallback> callback(
new DummyProofVerifierCallback);
QuicAsyncStatus status = proof_verifier.VerifyProof(
- kTestHostname, kTestConfig, QUIC_VERSION_25, "", certs_, "", kTestConfig,
- verify_context_.get(), &error_details_, &details_, callback.get());
+ kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_25, "", certs_, "",
+ kTestConfig, verify_context_.get(), &error_details_, &details_,
+ callback.get());
ASSERT_EQ(QUIC_FAILURE, status);
}
@@ -300,7 +302,7 @@ TEST_F(ProofVerifierChromiumTest, PreservesEVIfNoPolicy) {
scoped_ptr<DummyProofVerifierCallback> callback(
new DummyProofVerifierCallback);
QuicAsyncStatus status = proof_verifier.VerifyProof(
- kTestHostname, kTestConfig, QUIC_VERSION_25, "", certs_, "",
+ kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_25, "", certs_, "",
GetTestSignature(), verify_context_.get(), &error_details_, &details_,
callback.get());
ASSERT_EQ(QUIC_SUCCESS, status);
@@ -333,7 +335,7 @@ TEST_F(ProofVerifierChromiumTest, PreservesEVIfAllowed) {
scoped_ptr<DummyProofVerifierCallback> callback(
new DummyProofVerifierCallback);
QuicAsyncStatus status = proof_verifier.VerifyProof(
- kTestHostname, kTestConfig, QUIC_VERSION_25, "", certs_, "",
+ kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_25, "", certs_, "",
GetTestSignature(), verify_context_.get(), &error_details_, &details_,
callback.get());
ASSERT_EQ(QUIC_SUCCESS, status);
@@ -366,7 +368,7 @@ TEST_F(ProofVerifierChromiumTest, StripsEVIfNotAllowed) {
scoped_ptr<DummyProofVerifierCallback> callback(
new DummyProofVerifierCallback);
QuicAsyncStatus status = proof_verifier.VerifyProof(
- kTestHostname, kTestConfig, QUIC_VERSION_25, "", certs_, "",
+ kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_25, "", certs_, "",
GetTestSignature(), verify_context_.get(), &error_details_, &details_,
callback.get());
ASSERT_EQ(QUIC_SUCCESS, status);
@@ -400,7 +402,7 @@ TEST_F(ProofVerifierChromiumTest, IgnoresPolicyEnforcerIfNotEV) {
scoped_ptr<DummyProofVerifierCallback> callback(
new DummyProofVerifierCallback);
QuicAsyncStatus status = proof_verifier.VerifyProof(
- kTestHostname, kTestConfig, QUIC_VERSION_25, "", certs_, "",
+ kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_25, "", certs_, "",
GetTestSignature(), verify_context_.get(), &error_details_, &details_,
callback.get());
ASSERT_EQ(QUIC_SUCCESS, status);
« no previous file with comments | « net/quic/crypto/proof_verifier_chromium.cc ('k') | net/quic/quic_crypto_client_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698