Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: net/quic/crypto/proof_verifier_chromium_test.cc

Issue 1780983002: Provide valid port on HPKP reports for QUIC connections (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix missed tests Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/crypto/proof_verifier_chromium_test.cc
diff --git a/net/quic/crypto/proof_verifier_chromium_test.cc b/net/quic/crypto/proof_verifier_chromium_test.cc
index 19ccdef85e0f75294aae885a1b379f9b3d20d52b..8250d707331643fd1d30b1115ae5ef892ebe903f 100644
--- a/net/quic/crypto/proof_verifier_chromium_test.cc
+++ b/net/quic/crypto/proof_verifier_chromium_test.cc
@@ -101,6 +101,7 @@ class DummyProofVerifierCallback : public ProofVerifierCallback {
};
const char kTestHostname[] = "test.example.com";
+const uint16_t kTestPort = 8443;
const char kTestConfig[] = "server config bytes";
const char kLogDescription[] = "somelog";
@@ -222,7 +223,7 @@ TEST_F(ProofVerifierChromiumTest, FailsIfCertFails) {
scoped_ptr<DummyProofVerifierCallback> callback(
new DummyProofVerifierCallback);
QuicAsyncStatus status = proof_verifier.VerifyProof(
- kTestHostname, kTestConfig, certs_, "", GetTestSignature(),
+ kTestHostname, kTestPort, kTestConfig, certs_, "", GetTestSignature(),
verify_context_.get(), &error_details_, &details_, callback.get());
ASSERT_EQ(QUIC_FAILURE, status);
}
@@ -239,8 +240,8 @@ TEST_F(ProofVerifierChromiumTest, ValidSCTList) {
scoped_ptr<DummyProofVerifierCallback> callback(
new DummyProofVerifierCallback);
QuicAsyncStatus status = proof_verifier.VerifyProof(
- kTestHostname, kTestConfig, certs_, ct::GetSCTListForTesting(), "",
- verify_context_.get(), &error_details_, &details_, callback.get());
+ kTestHostname, kTestPort, kTestConfig, certs_, ct::GetSCTListForTesting(),
+ "", verify_context_.get(), &error_details_, &details_, callback.get());
ASSERT_EQ(QUIC_FAILURE, status);
CheckSCT(/*sct_expected_ok=*/true);
}
@@ -257,8 +258,9 @@ TEST_F(ProofVerifierChromiumTest, InvalidSCTList) {
scoped_ptr<DummyProofVerifierCallback> callback(
new DummyProofVerifierCallback);
QuicAsyncStatus status = proof_verifier.VerifyProof(
- kTestHostname, kTestConfig, certs_, ct::GetSCTListWithInvalidSCT(), "",
- verify_context_.get(), &error_details_, &details_, callback.get());
+ kTestHostname, kTestPort, kTestConfig, certs_,
+ ct::GetSCTListWithInvalidSCT(), "", verify_context_.get(),
+ &error_details_, &details_, callback.get());
ASSERT_EQ(QUIC_FAILURE, status);
CheckSCT(/*sct_expected_ok=*/false);
}
@@ -273,7 +275,7 @@ TEST_F(ProofVerifierChromiumTest, FailsIfSignatureFails) {
scoped_ptr<DummyProofVerifierCallback> callback(
new DummyProofVerifierCallback);
QuicAsyncStatus status = proof_verifier.VerifyProof(
- kTestHostname, kTestConfig, certs_, "", kTestConfig,
+ kTestHostname, kTestPort, kTestConfig, certs_, "", kTestConfig,
verify_context_.get(), &error_details_, &details_, callback.get());
ASSERT_EQ(QUIC_FAILURE, status);
}
@@ -297,7 +299,7 @@ TEST_F(ProofVerifierChromiumTest, PreservesEVIfNoPolicy) {
scoped_ptr<DummyProofVerifierCallback> callback(
new DummyProofVerifierCallback);
QuicAsyncStatus status = proof_verifier.VerifyProof(
- kTestHostname, kTestConfig, certs_, "", GetTestSignature(),
+ kTestHostname, kTestPort, kTestConfig, certs_, "", GetTestSignature(),
verify_context_.get(), &error_details_, &details_, callback.get());
ASSERT_EQ(QUIC_SUCCESS, status);
@@ -329,7 +331,7 @@ TEST_F(ProofVerifierChromiumTest, PreservesEVIfAllowed) {
scoped_ptr<DummyProofVerifierCallback> callback(
new DummyProofVerifierCallback);
QuicAsyncStatus status = proof_verifier.VerifyProof(
- kTestHostname, kTestConfig, certs_, "", GetTestSignature(),
+ kTestHostname, kTestPort, kTestConfig, certs_, "", GetTestSignature(),
verify_context_.get(), &error_details_, &details_, callback.get());
ASSERT_EQ(QUIC_SUCCESS, status);
@@ -361,7 +363,7 @@ TEST_F(ProofVerifierChromiumTest, StripsEVIfNotAllowed) {
scoped_ptr<DummyProofVerifierCallback> callback(
new DummyProofVerifierCallback);
QuicAsyncStatus status = proof_verifier.VerifyProof(
- kTestHostname, kTestConfig, certs_, "", GetTestSignature(),
+ kTestHostname, kTestPort, kTestConfig, certs_, "", GetTestSignature(),
verify_context_.get(), &error_details_, &details_, callback.get());
ASSERT_EQ(QUIC_SUCCESS, status);
@@ -394,7 +396,7 @@ TEST_F(ProofVerifierChromiumTest, IgnoresPolicyEnforcerIfNotEV) {
scoped_ptr<DummyProofVerifierCallback> callback(
new DummyProofVerifierCallback);
QuicAsyncStatus status = proof_verifier.VerifyProof(
- kTestHostname, kTestConfig, certs_, "", GetTestSignature(),
+ kTestHostname, kTestPort, kTestConfig, certs_, "", GetTestSignature(),
verify_context_.get(), &error_details_, &details_, callback.get());
ASSERT_EQ(QUIC_SUCCESS, status);

Powered by Google App Engine
This is Rietveld 408576698