Issue 1780973004: Kill ShellConnection::WaitForInitialize

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1780973004: Kill ShellConnection::WaitForInitialize (Closed)

Created:
4 years, 9 months ago by Ken Rockot(use gerrit already)

Modified:
4 years, 9 months ago

Reviewers:

CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, kalyank, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@fuse-api

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Kill ShellConnection::WaitForInitialize This takes advantage of the new pipe fusion API to make connector() available immediately upon connection construction. No moar blocking. BUG=591742

Patch Set 1 : #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -40 lines)			Patch
M	chrome/app/mash/mash_runner.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/common/mojo/mojo_shell_connection_impl.h	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	content/common/mojo/mojo_shell_connection_impl.cc	View	4 chunks	+5 lines, -13 lines	0 comments	Download
M	mojo/shell/background/tests/background_shell_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	mojo/shell/public/cpp/lib/shell_connection.cc	View	2 chunks	+10 lines, -7 lines	0 comments	Download
M	mojo/shell/public/cpp/lib/shell_test.cc	View	3 chunks	+3 lines, -5 lines	0 comments	Download
M	mojo/shell/public/cpp/shell_connection.h	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	mojo/shell/public/cpp/shell_test.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	mojo/shell/tests/shell/shell_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/views/mus/platform_test_helper_mus.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Depends on Patchset:

Issue 1785843002 Patch 80001

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Ken Rockot(use gerrit already)

4 years, 9 months ago (2016-03-11 05:21:39 UTC) #1

Patchset #1 (id:1) has been deleted

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages