content/renderer/mus/compositor_mus_connection.cc - Issue 1780953003: Change the non-blocking event queue to the main thread event queue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/mus/compositor_mus_connection.cc

Issue 1780953003: Change the non-blocking event queue to the main thread event queue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_wheel_regression_5

Patch Set: Fix up issues from patch set 2 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/input/main_thread_event_queue.cc ('K') | « content/renderer/input/render_widget_input_handler_delegate.h ('k') | content/renderer/mus/render_widget_mus_connection.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/mus/compositor_mus_connection.cc

diff --git a/content/renderer/mus/compositor_mus_connection.cc b/content/renderer/mus/compositor_mus_connection.cc

index 6973de6f6661938c064804b8e4fd6e766db3fa47..3934204b88e602d38cdf4ebfd17e39d2ee55bf37 100644

--- a/content/renderer/mus/compositor_mus_connection.cc

+++ b/content/renderer/mus/compositor_mus_connection.cc

@@ -120,8 +120,7 @@ void CompositorMusConnection::OnWindowInputEvent(

if (ack_state != INPUT_EVENT_ACK_STATE_NOT_CONSUMED)

return;

base::Closure ack = base::Bind(&base::DoNothing);

- const bool send_ack =

- WebInputEventTraits::WillReceiveAckFromRenderer(*web_event);

+ const bool send_ack = WebInputEventTraits::ShouldBlockEventStream(*web_event);

if (send_ack) {

// Ultimately, this ACK needs to go back to the Mus client lib which is not

// thread-safe and lives on the compositor thread. For ACKs that are passed