Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: content/common/input/input_event_dispatch_type.h

Issue 1780953003: Change the non-blocking event queue to the main thread event queue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_wheel_regression_5
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/content_renderer.gypi » ('j') | content/renderer/input/main_thread_event_queue.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/input/input_event_dispatch_type.h
diff --git a/content/common/input/input_event_dispatch_type.h b/content/common/input/input_event_dispatch_type.h
index e4acb4c1cee93f8760d801ae2dc684fcf4b43a9d..379f1eb9c09d9ee6edd0654286bbc2f00dcae540 100644
--- a/content/common/input/input_event_dispatch_type.h
+++ b/content/common/input/input_event_dispatch_type.h
@@ -8,9 +8,13 @@
namespace content {
enum InputEventDispatchType {
tdresser 2016/03/10 20:12:05 InputEventMainThreadDispatchType
dtapuska 2016/03/14 17:33:27 I'm not I sure I agree with this.
tdresser 2016/03/15 13:41:21 You're right, it's correct as is.
- DISPATCH_TYPE_NORMAL, // Dispatch a normal event.
- DISPATCH_TYPE_NON_BLOCKING, // Dispatch a non-blocking event.
- DISPATCH_TYPE_MAX = DISPATCH_TYPE_NON_BLOCKING
+ DISPATCH_TYPE_NORMAL, // Dispatch a normal event.
tdresser 2016/03/10 20:12:05 DISPATCH_TYPE_BLOCKING?
dtapuska 2016/03/14 17:33:27 Done.
+ DISPATCH_TYPE_NORMAL_NOTIFY_MAIN, // Dispatch a normal event and notify main
tdresser 2016/03/10 20:12:05 DISPATCH_TYPE_BLOCKING_ACK_TO_MAIN?
dtapuska 2016/03/14 17:33:27 ACK_TO_MAIN is confusing because the ACK is sent t
tdresser 2016/03/15 13:41:21 Acknowledged.
+ // thread.
+ DISPATCH_TYPE_NON_BLOCKING, // Dispatch a non-blocking event.
+ DISPATCH_TYPE_NON_BLOCKING_NOTIFY_MAIN, // Dispatch a non-blocking event and
+ // notify main thread.
+ DISPATCH_TYPE_MAX = DISPATCH_TYPE_NON_BLOCKING_NOTIFY_MAIN
};
} // namespace content
« no previous file with comments | « no previous file | content/content_renderer.gypi » ('j') | content/renderer/input/main_thread_event_queue.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698