Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1780943003: [ios] Disabled LoadsCorrectHTML on device. (Closed)

Created:
4 years, 9 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 9 months ago
Reviewers:
baxley, Jackie Quinn
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Disabled LoadsCorrectHTML on device. For some reason flaky tests still run on the main waterfall. BUG=592034 Committed: https://crrev.com/473965519185e7f511cc23fa441ec738a340a3a9 Cr-Commit-Position: refs/heads/master@{#380471}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ios/web/web_state/js/crw_js_post_request_loader_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
Eugene But (OOO till 7-30)
4 years, 9 months ago (2016-03-10 16:17:15 UTC) #2
Eugene But (OOO till 7-30)
4 years, 9 months ago (2016-03-10 16:17:25 UTC) #4
Jackie Quinn
lgtm, but make sure there's a bug tracking FLAKY_ labeling issues.
4 years, 9 months ago (2016-03-10 17:52:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780943003/1
4 years, 9 months ago (2016-03-10 17:54:47 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/194747)
4 years, 9 months ago (2016-03-10 19:50:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780943003/1
4 years, 9 months ago (2016-03-10 21:03:20 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 21:33:48 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/473965519185e7f511cc23fa441ec738a340a3a9 Cr-Commit-Position: refs/heads/master@{#380471}
4 years, 9 months ago (2016-03-10 21:34:57 UTC) #14
baxley
4 years, 9 months ago (2016-03-10 23:04:48 UTC) #16
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698