Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1780933004: Fix post-mortem data after frame-marking changes (Closed)

Created:
4 years, 9 months ago by ofrobots
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix post-mortem data after frame-marking changes Post-mortem metadata generation broke as a result of https://codereview.chromium.org/1696043002 BUG= Committed: https://crrev.com/cbd91c52088bf953ac529ba6d07084e8b818e15c Cr-Commit-Position: refs/heads/master@{#34725}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M tools/gen-postmortem-metadata.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
ofrobots
On 2016/03/10 22:05:03, ofrobots wrote: > mailto:ofrobots@google.com changed reviewers: > + mailto:danno@chromium.org, mailto:machenbach@chromium.org danno@: PTAL.
4 years, 9 months ago (2016-03-10 22:05:48 UTC) #3
Michael Achenbach
lgtm - rubber stamp
4 years, 9 months ago (2016-03-11 08:25:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780933004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780933004/1
4 years, 9 months ago (2016-03-11 13:21:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 15:10:30 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 15:12:11 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/cbd91c52088bf953ac529ba6d07084e8b818e15c
Cr-Commit-Position: refs/heads/master@{#34725}

Powered by Google App Engine
This is Rietveld 408576698