Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkThumbnailWidgetProviderBase.java

Issue 1780893005: Visual refresh for bookmarks widget. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: design tweaks Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkThumbnailWidgetProviderBase.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkThumbnailWidgetProviderBase.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkThumbnailWidgetProviderBase.java
index 33096232ab60796631db42cab7c4dea16722a343..9fa13c3136334856b5b19d22fdd8c70ac0288bfa 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkThumbnailWidgetProviderBase.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkThumbnailWidgetProviderBase.java
@@ -92,12 +92,6 @@ public class BookmarkThumbnailWidgetProviderBase extends AppWidgetProvider {
private void performUpdate(Context context,
AppWidgetManager appWidgetManager, int[] appWidgetIds) {
- Intent chromeIntent = new Intent(Intent.ACTION_MAIN);
Ian Wen 2016/03/28 18:26:29 Could you explain this change a bit? I wonder why
newt (away) 2016/03/28 19:55:25 The old design had a Chrome icon in the bottom rig
- chromeIntent.setPackage(context.getPackageName());
-
- PendingIntent launchChrome = PendingIntent.getActivity(context, 0, chromeIntent,
- PendingIntent.FLAG_UPDATE_CURRENT);
-
for (int appWidgetId : appWidgetIds) {
Intent updateIntent = new Intent(context, BookmarkThumbnailWidgetService.class);
updateIntent.putExtra(AppWidgetManager.EXTRA_APPWIDGET_ID, appWidgetId);
@@ -105,7 +99,6 @@ public class BookmarkThumbnailWidgetProviderBase extends AppWidgetProvider {
RemoteViews views = new RemoteViews(context.getPackageName(),
R.layout.bookmark_thumbnail_widget);
- views.setOnClickPendingIntent(R.id.app_shortcut, launchChrome);
views.setRemoteAdapter(R.id.bookmarks_list, updateIntent);
appWidgetManager.notifyAppWidgetViewDataChanged(appWidgetId, R.id.bookmarks_list);

Powered by Google App Engine
This is Rietveld 408576698