Visual refresh for bookmarks widget.

Visual refresh for bookmarks widget.

This brings the bookmarks widget into the Material era. The widget now
shows a list of bookmarks that resembles the bookmarks UI in Chrome.

BUG=593587
Committed: https://crrev.com/dcbe9dcac80b672ed6396a843381c23c7762a9d9
Cr-Commit-Position: refs/heads/master@{#383795}

[newt (away), 2016-03-25 23:19:36]

newt@chromium.org changed reviewers:
+ ianwen@chromium.org

[newt (away), 2016-03-25 23:19:37]

PTAL. Thanks!

https://codereview.chromium.org/1780893005/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkThumbnailWidgetService.java
(right):

https://codereview.chromium.org/1780893005/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkThumbnailWidgetService.java:385:
private BookmarkFolder loadBookmarks(final BookmarkId folderId) {
Moved this logic down from the old "loadBookmarksOnBinderThread()" method. Now
BookmarkLoader is used only the UI thread, which I think is simpler.

[newt (away), 2016-03-25 23:22:43]

Screenshot on the bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=593587#c4

[Ian Wen, 2016-03-28 18:26:29]

Wow such a nice CL!

https://codereview.chromium.org/1780893005/diff/40001/chrome/android/java/res...
File chrome/android/java/res/xml/bookmark_thumbnail_widget_info.xml (left):

https://codereview.chromium.org/1780893005/diff/40001/chrome/android/java/res...
chrome/android/java/res/xml/bookmark_thumbnail_widget_info.xml:2: <!-- Copyright
2015 The Chromium Authors. All rights reserved.
Maybe we should remove the word "thumbnail" in the xml filenames?

https://codereview.chromium.org/1780893005/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkThumbnailWidgetProviderBase.java
(left):

https://codereview.chromium.org/1780893005/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkThumbnailWidgetProviderBase.java:95:
Intent chromeIntent = new Intent(Intent.ACTION_MAIN);
Could you explain this change a bit?

I wonder why we no longer launch chrome when the items are clicked.

[newt (away), 2016-03-28 19:55:26]

Thanks for reviewing :)

https://codereview.chromium.org/1780893005/diff/40001/chrome/android/java/res...
File chrome/android/java/res/xml/bookmark_thumbnail_widget_info.xml (left):

https://codereview.chromium.org/1780893005/diff/40001/chrome/android/java/res...
chrome/android/java/res/xml/bookmark_thumbnail_widget_info.xml:2: <!-- Copyright
2015 The Chromium Authors. All rights reserved.
On 2016/03/28 18:26:29, Ian Wen wrote:
> Maybe we should remove the word "thumbnail" in the xml filenames?

Indeed! You read my mind :)

I'm planning to remove "thumbnail" from all the filenames in a follow-up CL.
(Doing it in a separate CL will make reviewing easier and make the history
easier to follow.)

https://codereview.chromium.org/1780893005/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkThumbnailWidgetProviderBase.java
(left):

https://codereview.chromium.org/1780893005/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkThumbnailWidgetProviderBase.java:95:
Intent chromeIntent = new Intent(Intent.ACTION_MAIN);
On 2016/03/28 18:26:29, Ian Wen wrote:
> Could you explain this change a bit?
> 
> I wonder why we no longer launch chrome when the items are clicked.

The old design had a Chrome icon in the bottom right corner of the widget. When
the user clicked the icon, we'd launch Chrome. The new design doesn't have the
Chrome icon so we don't need this code anymore.

Note: When the user clicks on a bookmark a different intent is fired (see
"Intent ic" below and "Intent fillIn" at the bottom of getViewAt() in
BookmarkThumbnailWidgetService). This CL doesn't change that behavior.

[Ian Wen, 2016-03-29 19:00:12]

lgtm

[newt (away), 2016-03-29 19:03:14]

The CQ bit was checked by newt@chromium.org

[newt (away), 2016-03-29 19:03:23]

The CQ bit was unchecked by newt@chromium.org

[commit-bot: I haz the power, 2016-03-29 19:03:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1780893005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1780893005/40001

[newt (away), 2016-03-29 19:04:21]

The CQ bit was checked by newt@chromium.org

[newt (away), 2016-03-29 19:04:22]

The patchset sent to the CQ was uploaded after l-g-t-m from ianwen@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1780893005/#ps60001
(title: "rebased")

[commit-bot: I haz the power, 2016-03-29 19:04:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1780893005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1780893005/60001

[commit-bot: I haz the power, 2016-03-29 19:45:26]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-29 19:46:27]

Description was changed from

==========
Visual refresh for bookmarks widget.

This brings the bookmarks widget into the Material era. The widget now
shows a list of bookmarks that resembles the bookmarks UI in Chrome.

BUG=593587
==========

to

==========
Visual refresh for bookmarks widget.

This brings the bookmarks widget into the Material era. The widget now
shows a list of bookmarks that resembles the bookmarks UI in Chrome.

BUG=593587

Committed: https://crrev.com/dcbe9dcac80b672ed6396a843381c23c7762a9d9
Cr-Commit-Position: refs/heads/master@{#383795}
==========

[commit-bot: I haz the power, 2016-03-29 19:46:28]

Patchset 4 (id:??) landed as
https://crrev.com/dcbe9dcac80b672ed6396a843381c23c7762a9d9
Cr-Commit-Position: refs/heads/master@{#383795}