Issue 1780883002: Move element handles out of generated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1780883002: Move element handles out of generated (Closed)

Created:
4 years, 9 months ago by Brian Wilkerson

Modified:
4 years, 9 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+105 lines, -1213 lines)			Patch
M	pkg/analyzer/lib/src/dart/element/element.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	pkg/analyzer/lib/src/dart/element/handle.dart	View	23 chunks	+98 lines, -115 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/constant.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/element_handle.dart	View	1 chunk	+2 lines, -1093 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/resynthesize.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/test/src/summary/resynthesize_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Brian Wilkerson

Other than moving code and cleaning up comments, there are no changes.

4 years, 9 months ago (2016-03-10 04:27:24 UTC) #2

Brian Wilkerson

4 years, 9 months ago (2016-03-10 15:40:42 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1a455bcb9d859d158cb4fc3860859f415488679d (presubmit successful).