Check that Promise subclasses have callable resolve/reject

Check that Promise subclasses have callable resolve/reject

This check is guaranteed by the Promise spec and tested by test262
tests. It only has to run for subclasses. This patch adds the check
to the Promise code.

BUG=v8:4633
R=adamk
LOG=Y

Committed: https://crrev.com/d9c45337a49f01ff3beadba860307e740ced7480
Cr-Commit-Position: refs/heads/master@{#34693}

[Dan Ehrenberg, 2016-03-10 01:17:16]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-10 01:17:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1780823003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1780823003/1

[commit-bot: I haz the power, 2016-03-10 01:31:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 01:31:12]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)

[adamk, 2016-03-10 01:39:48]

Patch lgtm, but looks like we might have tests that have different behavior.

[Dan Ehrenberg, 2016-03-10 02:37:47]

On 2016/03/10 at 01:39:48, adamk wrote:
> Patch lgtm, but looks like we might have tests that have different behavior.

Looks like that test was testing for behavior that contravenes the spec. I
changed the test to test for the new behavior. Does it still seem good?

[adamk, 2016-03-10 02:53:05]

adamk@chromium.org changed reviewers:
+ rossberg@chromium.org

[adamk, 2016-03-10 02:53:06]

If it passes test262 and everything else, probably looks good, but I'd want to
make sure we're not losing test coverage.

https://codereview.chromium.org/1780823003/diff/20001/test/mjsunit/es6/debug-...
File test/mjsunit/es6/debug-promises/throw-with-undefined-reject.js (left):

https://codereview.chromium.org/1780823003/diff/20001/test/mjsunit/es6/debug-...
test/mjsunit/es6/debug-promises/throw-with-undefined-reject.js:7: // Test debug
events when an exception is thrown inside a Promise, which is
Was this test simply impossible to get as far with, given the ES2015 text?

[Dan Ehrenberg, 2016-03-10 20:00:42]

https://codereview.chromium.org/1780823003/diff/20001/test/mjsunit/es6/debug-...
File test/mjsunit/es6/debug-promises/throw-with-undefined-reject.js (left):

https://codereview.chromium.org/1780823003/diff/20001/test/mjsunit/es6/debug-...
test/mjsunit/es6/debug-promises/throw-with-undefined-reject.js:7: // Test debug
events when an exception is thrown inside a Promise, which is
On 2016/03/10 at 02:53:06, adamk wrote:
> Was this test simply impossible to get as far with, given the ES2015 text?

There's no such thing as "having no reject handler" in ES2015 promises. In the
debug-promises directory, there are many other tests which check various
rejection paths, such as mjsunit/es6/debug-promises/reject-with-throw-in-reject
.

[Dan Ehrenberg, 2016-03-10 20:01:21]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-10 20:01:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1780823003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1780823003/20001

[adamk, 2016-03-10 20:02:55]

lgtm

[Dan Ehrenberg, 2016-03-10 20:07:25]

The CQ bit was unchecked by littledan@chromium.org

[Dan Ehrenberg, 2016-03-10 20:07:27]

The CQ bit was checked by littledan@chromium.org

[commit-bot: I haz the power, 2016-03-10 20:07:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1780823003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1780823003/20001

[Dan Ehrenberg, 2016-03-10 23:17:07]

The CQ bit was unchecked by littledan@chromium.org

[Dan Ehrenberg, 2016-03-10 23:17:09]

The CQ bit was checked by littledan@chromium.org

[commit-bot: I haz the power, 2016-03-10 23:17:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1780823003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1780823003/20001

[commit-bot: I haz the power, 2016-03-10 23:20:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-10 23:22:39]

Description was changed from

==========
Check that Promise subclasses have callable resolve/reject

This check is guaranteed by the Promise spec and tested by test262
tests. It only has to run for subclasses. This patch adds the check
to the Promise code.

BUG=v8:4633
R=adamk
LOG=Y
==========

to

==========
Check that Promise subclasses have callable resolve/reject

This check is guaranteed by the Promise spec and tested by test262
tests. It only has to run for subclasses. This patch adds the check
to the Promise code.

BUG=v8:4633
R=adamk
LOG=Y

Committed: https://crrev.com/d9c45337a49f01ff3beadba860307e740ced7480
Cr-Commit-Position: refs/heads/master@{#34693}
==========

[commit-bot: I haz the power, 2016-03-10 23:22:40]

Patchset 2 (id:??) landed as
https://crrev.com/d9c45337a49f01ff3beadba860307e740ced7480
Cr-Commit-Position: refs/heads/master@{#34693}