Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

Issue 1780803002: Timeline: show RAIL phase strip unconditionally on actual records being present (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 541 matching lines...) Expand 10 before | Expand all | Expand 10 after
552 _appendGPUEvents: function() 552 _appendGPUEvents: function()
553 { 553 {
554 if (this._appendSyncEvents(this._model.gpuTasks().map(record => record.t raceEvent()), WebInspector.UIString("GPU"), this._headerLevel1)) 554 if (this._appendSyncEvents(this._model.gpuTasks().map(record => record.t raceEvent()), WebInspector.UIString("GPU"), this._headerLevel1))
555 ++this._currentLevel; 555 ++this._currentLevel;
556 }, 556 },
557 557
558 _appendInteractionRecords: function() 558 _appendInteractionRecords: function()
559 { 559 {
560 if (!this._irModel) 560 if (!this._irModel)
561 return; 561 return;
562 var segments = this._irModel.interactionRecords(); 562 this._irModel.interactionRecords().forEach(this._appendSegment, this);
563 if (!segments || !segments.length)
564 return;
565 segments.forEach(this._appendSegment, this);
566 this._entryTypeByLevel[this._currentLevel++] = WebInspector.TimelineFlam eChartEntryType.InteractionRecord; 563 this._entryTypeByLevel[this._currentLevel++] = WebInspector.TimelineFlam eChartEntryType.InteractionRecord;
567 }, 564 },
568 565
569 /** 566 /**
570 * @param {!Array.<!WebInspector.TimelineFrame>} frames 567 * @param {!Array.<!WebInspector.TimelineFrame>} frames
571 */ 568 */
572 _appendFrameBars: function(frames) 569 _appendFrameBars: function(frames)
573 { 570 {
574 var style = WebInspector.TimelineUIUtils.markerStyleForFrame(); 571 var style = WebInspector.TimelineUIUtils.markerStyleForFrame();
575 this._entryTypeByLevel[this._currentLevel] = WebInspector.TimelineFlameC hartEntryType.Frame; 572 this._entryTypeByLevel[this._currentLevel] = WebInspector.TimelineFlameC hartEntryType.Frame;
(...skipping 898 matching lines...) Expand 10 before | Expand all | Expand 10 after
1474 /** 1471 /**
1475 * @constructor 1472 * @constructor
1476 * @param {!WebInspector.TimelineSelection} selection 1473 * @param {!WebInspector.TimelineSelection} selection
1477 * @param {number} entryIndex 1474 * @param {number} entryIndex
1478 */ 1475 */
1479 WebInspector.TimelineFlameChartView.Selection = function(selection, entryIndex) 1476 WebInspector.TimelineFlameChartView.Selection = function(selection, entryIndex)
1480 { 1477 {
1481 this.timelineSelection = selection; 1478 this.timelineSelection = selection;
1482 this.entryIndex = entryIndex; 1479 this.entryIndex = entryIndex;
1483 } 1480 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698