Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Unified Diff: src/IceTargetLoweringX86Base.h

Issue 1780773003: Re-fix build errors from upgrading to clang 3.9 . (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceTargetLoweringX86Base.h
diff --git a/src/IceTargetLoweringX86Base.h b/src/IceTargetLoweringX86Base.h
index 01298eb53910b9d006f1a51aadb2077d766b38be..48f04abbd6c65b7aacbb0f4511683e5301866a38 100644
--- a/src/IceTargetLoweringX86Base.h
+++ b/src/IceTargetLoweringX86Base.h
@@ -79,10 +79,6 @@ public:
~TargetX86Base() override = default;
static void staticInit(GlobalContext *Ctx);
- static TargetX86Base *create(Cfg *Func) { return new TargetX86Base(Func); }
- std::unique_ptr<::Ice::Assembler> createAssembler() const override {
- return nullptr;
- }
static FixupKind getPcRelFixup() { return PcRelFixup; }
static FixupKind getAbsFixup() { return AbsFixup; }
@@ -356,17 +352,10 @@ protected:
}
/// Emit just the call instruction (without argument or return variable
/// processing), sandboxing if needed.
- virtual Inst *emitCallToTarget(Operand *CallTarget, Variable *ReturnReg) {
- (void)CallTarget;
- (void)ReturnReg;
- return nullptr;
- }
+ virtual Inst *emitCallToTarget(Operand *CallTarget, Variable *ReturnReg) = 0;
/// Materialize the moves needed to return a value of the specified type.
- virtual Variable *moveReturnValueToRegister(Operand *Value, Type ReturnType) {
- (void)Value;
- (void)ReturnType;
- return nullptr;
- }
+ virtual Variable *moveReturnValueToRegister(Operand *Value,
+ Type ReturnType) = 0;
/// Emit a jump table to the constant pool.
void emitJumpTable(const Cfg *Func,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698