scripts/slave/recipe_modules/auto_bisect/bisector.py - Issue 1780753004: Tweaking classifying algorithm constants to reduce false positives.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/auto_bisect/bisector.py

Issue 1780753004: Tweaking classifying algorithm constants to reduce false positives. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/auto_bisect/bisector.py

diff --git a/scripts/slave/recipe_modules/auto_bisect/bisector.py b/scripts/slave/recipe_modules/auto_bisect/bisector.py

index 34bce59c9899cf08a8863c06d36f69d7bf015579..c17e496b885b1d5e9eb9ad7b8e80a21a29357823 100644

--- a/scripts/slave/recipe_modules/auto_bisect/bisector.py

+++ b/scripts/slave/recipe_modules/auto_bisect/bisector.py

@@ -48,11 +48,11 @@ DEFAULT_SEARCH_RANGE_PERCENTAGE = 0.25

REGRESSION_CHECK_TIMEOUT = 2 * 60 * 60

# If we reach this number of samples on the reference range and have not

# achieved statistical significance, bail.

-MAX_REQUIRED_SAMPLES = 50

+MAX_REQUIRED_SAMPLES = 25

# Significance level to use for determining difference between revisions via

# hypothesis testing.

-SIGNIFICANCE_LEVEL = 0.01

+SIGNIFICANCE_LEVEL = 0.005

_FAILED_INITIAL_CONFIDENCE_ABORT_REASON = (

'The metric values for the initial "good" and "bad" revisions '

« no previous file with comments | « no previous file | scripts/slave/recipe_modules/auto_bisect/example.expected/android_arm64_bisector.json » ('j') | no next file with comments »