Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: media/cast/transport/cast_transport_sender_impl.h

Issue 178073004: Cast: IPC from browser to renderer to send packet events from transport to cast library. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed hubbe's comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/transport/cast_transport_sender_impl.h
diff --git a/media/cast/transport/cast_transport_sender_impl.h b/media/cast/transport/cast_transport_sender_impl.h
index a8084f8737dca0cafbfc6e4fbe23bdfc97db4ce6..01655fe16cd21e63cacb32d5f73996fabe2c9565 100644
--- a/media/cast/transport/cast_transport_sender_impl.h
+++ b/media/cast/transport/cast_transport_sender_impl.h
@@ -10,6 +10,9 @@
#include "base/memory/scoped_ptr.h"
#include "base/time/tick_clock.h"
#include "base/time/time.h"
+#include "base/timer/timer.h"
+#include "media/cast/logging/logging_defines.h"
+#include "media/cast/logging/simple_event_subscriber.h"
#include "media/cast/transport/cast_transport_config.h"
#include "media/cast/transport/cast_transport_sender.h"
#include "media/cast/transport/pacing/paced_sender.h"
@@ -26,10 +29,13 @@ class CastTransportSenderImpl : public CastTransportSender {
// external_transport is only used for testing.
// Note that SetPacketReceiver does not work if an external
// transport is provided.
+ // |raw_events_callback|: Raw events will be returned on a regular interval
+ // on this callback.
CastTransportSenderImpl(
base::TickClock* clock,
const CastTransportConfig& config,
const CastTransportStatusCallback& status_callback,
+ const BulkRawEventsCallback& raw_events_callback,
const scoped_refptr<base::SingleThreadTaskRunner>& transport_task_runner,
PacketSender* external_transport);
@@ -65,12 +71,28 @@ class CastTransportSenderImpl : public CastTransportSender {
const CastTransportRtpStatistics& callback) OVERRIDE;
private:
+ // How often to send raw events.
+ static const int kSendRawEventsIntervalSecs = 1;
+
+ // If raw events logging is enabled, this is called periodically.
+ // Calls |raw_events_callback_| with events collected by |event_subscriber_|
+ // since last call.
+ void SendRawEvents();
+
scoped_ptr<UdpTransport> transport_;
PacedSender pacer_;
RtcpBuilder rtcp_builder_;
TransportAudioSender audio_sender_;
TransportVideoSender video_sender_;
+ LoggingImpl logging_;
+
+ // This is non-null iff raw events logging is enabled.
+ scoped_ptr<SimpleEventSubscriber> event_subscriber_;
+ base::RepeatingTimer<CastTransportSenderImpl> raw_events_timer_;
+
+ BulkRawEventsCallback raw_events_callback_;
+
DISALLOW_COPY_AND_ASSIGN(CastTransportSenderImpl);
};

Powered by Google App Engine
This is Rietveld 408576698