Cast: IPC from browser to renderer to send packet events from transport to cast library.

media/cast/logging/logging_defines.h

Index: media/cast/logging/logging_defines.h
diff --git a/media/cast/logging/logging_defines.h b/media/cast/logging/logging_defines.h
index 10529a2b64ab68d4fc3f2dad14a932822ad77db5..7e7c294779d2a12d82f04080b6ffd6751b7866e1 100644
--- a/media/cast/logging/logging_defines.h
+++ b/media/cast/logging/logging_defines.h
@@ -71,7 +71,7 @@ enum CastLoggingEvent {
   kVideoPacketReceived,
   kDuplicateAudioPacketReceived,
   kDuplicateVideoPacketReceived,
-  kNumOfLoggingEvents,
+  kNumOfLoggingEvents

[dcheng, 2014/02/27 22:27:20]

I think it would be better if this were kCastLoggingEventLast =
kDuplicateVideoPacketReceived

For an example, see
https://code.google.com/p/chromium/codesearch#chromium/src/ui/base/clipboard/...

This is also consistent with the naming of the other cast enums.

[imcheng, 2014/02/28 00:15:06]

I tried it but it doesn't work as well as I would have wanted. In particular
this messes up the places where we switch on the value, e.g.
CastLoggingToString() below. So I am not sure if setting kNumOfLoggingEvents =
kDuplicateVideoPacketReceived is worth it.

[dcheng, 2014/02/28 19:46:11]

Why would this complicate those functions?
case kNumOfLoggingEvents:
      NOTREACHED();
      return OTHER_EVENT;
should simply be removed. The compiler will warn if you don't handle all
possible num values in the switch anyway.

[imcheng, 2014/03/03 19:00:09]

Yes, that will work. But that will also make kNumOfLoggingEvents valid in code
paths which is something I didn't like. Anyway, I made the change to remove it
from switches so that it can be assigned to the same value as
kDuplicateVideoPacketReceived.

 };
 
 std::string CastLoggingToString(CastLoggingEvent event);