Cast: IPC from browser to renderer to send packet events from transport to cast library.

media/cast/audio_sender/audio_sender_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/test/simple_test_tick_clock.h"
 #include "media/base/media.h"
 #include "media/cast/audio_sender/audio_sender.h"
@@ skipping 66 matching lines @@
     audio_config_.bitrate = kDefaultAudioEncoderBitrate;
     audio_config_.rtp_config.payload_type = 127;
 
     transport::CastTransportConfig transport_config;
     transport_config.audio_rtp_config.payload_type = 127;
     transport_config.audio_channels = 2;
     transport_sender_.reset(new transport::CastTransportSenderImpl(
         testing_clock_,
         transport_config,
         base::Bind(&UpdateCastTransportStatus),
+        base::Bind(&IgnoreRawEvents),
         task_runner_,
         &transport_));
     audio_sender_.reset(new AudioSender(
         cast_environment_, audio_config_, transport_sender_.get()));
     task_runner_->RunTasks();
   }
 
   virtual ~AudioSenderTest() {}
 
   static void UpdateCastTransportStatus(transport::CastTransportStatus status) {
     EXPECT_EQ(status, transport::TRANSPORT_INITIALIZED);
   }
 
+  static void IgnoreRawEvents(const std::vector<PacketEvent>& packet_events) {
+    // Do nothing, we don't care about logging in this test.

[hubbe, 2014/02/26 01:01:07]

Is there *anything* we can add here to make it actually care a little bit?

[imcheng, 2014/02/26 10:08:26]

Not really. Logging is disabled in this test, so this callback is never invoked.
We could FAIL() here, but that's not very meaningful. This makes me wonder if
this could be designed a little bit better - from the caller's perspective, it
will be good to not have to specify callback if logging is disabled. Since only
some test code doesn't care about logging, I modified the constructor to check
for null callbacks, which it will interpret as "don't care about logging".

+  }
+
   base::SimpleTestTickClock* testing_clock_;  // Owned by CastEnvironment.
   TestPacketSender transport_;
   scoped_ptr<transport::CastTransportSenderImpl> transport_sender_;
   scoped_refptr<test::FakeSingleThreadTaskRunner> task_runner_;
   scoped_ptr<AudioSender> audio_sender_;
   scoped_refptr<CastEnvironment> cast_environment_;
   AudioSenderConfig audio_config_;
 };
 
 TEST_F(AudioSenderTest, Encode20ms) {
@@ skipping 38 matching lines @@
   base::TimeDelta max_rtcp_timeout =
       base::TimeDelta::FromMilliseconds(1 + kDefaultRtcpIntervalMs * 3 / 2);
   testing_clock_->Advance(max_rtcp_timeout);
   task_runner_->RunTasks();
   EXPECT_GE(transport_.number_of_rtp_packets(), 1);
   EXPECT_EQ(transport_.number_of_rtcp_packets(), 1);
 }
 
 }  // namespace cast
 }  // namespace media