Cast: IPC from browser to renderer to send packet events from transport to cast library.

chrome/renderer/media/cast_ipc_dispatcher.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/media/cast_ipc_dispatcher.h"
 
 #include "chrome/common/cast_messages.h"
 #include "chrome/renderer/media/cast_transport_sender_ipc.h"
 #include "ipc/ipc_message_macros.h"
 
@@ skipping 33 matching lines @@
   return id_map_.Remove(channel_id);
 }
 
 bool CastIPCDispatcher::OnMessageReceived(const IPC::Message& message) {
   DCHECK(io_message_loop_->BelongsToCurrentThread());
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(CastIPCDispatcher, message)
     IPC_MESSAGE_HANDLER(CastMsg_ReceivedPacket, OnReceivedPacket)
     IPC_MESSAGE_HANDLER(CastMsg_NotifyStatusChange, OnNotifyStatusChange)
     IPC_MESSAGE_HANDLER(CastMsg_RtpStatistics, OnRtpStatistics)
+    IPC_MESSAGE_HANDLER(CastMsg_RawEvents, OnRawEvents)
     IPC_MESSAGE_UNHANDLED(handled = false);
   IPC_END_MESSAGE_MAP();
   return handled;
 }
 
 void CastIPCDispatcher::OnFilterAdded(IPC::Channel* channel) {
   DCHECK(io_message_loop_->BelongsToCurrentThread());
   DCHECK(!global_instance_);
   global_instance_ = this;
   channel_ = channel;
@@ skipping 38 matching lines @@
 void CastIPCDispatcher::OnRtpStatistics(
     int32 channel_id,
     bool audio,
     const media::cast::transport::RtcpSenderInfo& sender_info,
     base::TimeTicks time_sent,
     uint32 rtp_timestamp) {
   CastTransportSenderIPC* sender = id_map_.Lookup(channel_id);
   if (sender) {
     sender->OnRtpStatistics(audio, sender_info, time_sent, rtp_timestamp);
   } else {
-    LOG(ERROR)
-        << "CastIPCDispatcher::OnNotifystatusChange on non-existing channel.";
+    LOG(ERROR) << "CastIPCDispatcher::OnRtpStatistics on non-existing channel.";
   }
 }
+
+void CastIPCDispatcher::OnRawEvents(
+    int32 channel_id,
+    const std::vector<media::cast::PacketEvent>& packet_events) {
+  CastTransportSenderIPC* sender = id_map_.Lookup(channel_id);
+  if (sender) {
+    sender->OnRawEvents(packet_events);
+  } else {
+    LOG(ERROR) << "CastIPCDispatcher::OnRawEvents on non-existing channel.";

[miu, 2014/02/26 22:43:51]

This, and the other LOG(ERROR) statements in this file, should either be removed
or changed to NOT_REACHED() instead.  If, we expect the |sender| look-up from
|id_map_| to fail under normal circumstances, we shouldn't be spamming the log
at all, since this is not an error.

[imcheng, 2014/02/26 23:35:55]

Is it an error? It looks like the CastTransportSenderIPC can be destroyed before
while browser side is sending a message for it. I think it should be expected
that lookups will sometimes fail. The log is still somewhat useful though for
debugging, so how about making these DVLOG(1), and consistent with
cast_transport_host_filter.cc?

[miu, 2014/02/26 23:57:52]

SGTM.  Can you fix the others too, please?

+  }
+}