Raise StackOverflow during bootstrapping

src/bootstrapper.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1459 matching lines @@
                             Vector<const char> name,
                             Handle<String> source) {
   HandleScope scope(isolate);
 #ifdef ENABLE_DEBUGGER_SUPPORT
   isolate->debugger()->set_compiling_natives(true);
 #endif
   // During genesis, the boilerplate for stack overflow won't work until the
   // environment has been at least partially initialized. Add a stack check
   // before entering JS code to catch overflow early.
   StackLimitCheck check(isolate);
-  if (check.HasOverflowed()) return false;
+  if (check.WillOverflow(5000 * sizeof(intptr_t))) {

[Jarin, 2014/02/25 20:45:08]

Could you possibly create some constant with some descriptive name for the
buffer space?

+    isolate->StackOverflow();
+    isolate->OptionalRescheduleException(true);
+    return false;
+  }
 
   bool result = CompileScriptCached(isolate,
                                     name,
                                     source,
                                     NULL,
                                     NULL,
                                     Handle<Context>(isolate->context()),
                                     true);
   ASSERT(isolate->has_pending_exception() != result);
   if (!result) isolate->clear_pending_exception();
@@ skipping 1110 matching lines @@
   if (!V8::Initialize(NULL)) return;
 
   // Before creating the roots we must save the context and restore it
   // on all function exits.
   SaveContext saved_context(isolate);
 
   // During genesis, the boilerplate for stack overflow won't work until the
   // environment has been at least partially initialized. Add a stack check
   // before entering JS code to catch overflow early.
   StackLimitCheck check(isolate);
-  if (check.HasOverflowed()) return;
+  if (check.WillOverflow(6000 * sizeof(intptr_t))) {

[Jarin, 2014/02/25 20:45:08]

Is there a reason why the magic constant differs from the one above?

+    isolate->StackOverflow();
+    isolate->OptionalRescheduleException(true);
+    return;
+  }
 
   // We can only de-serialize a context if the isolate was initialized from
   // a snapshot. Otherwise we have to build the context from scratch.
   if (isolate->initialized_from_snapshot()) {
     native_context_ = Snapshot::NewContextFromSnapshot(isolate);
   } else {
     native_context_ = Handle<Context>();
   }
 
   if (!native_context().is_null()) {
@@ skipping 124 matching lines @@
   return from + sizeof(NestingCounterType);
 }
 
 
 // Called when the top-level V8 mutex is destroyed.
 void Bootstrapper::FreeThreadResources() {
   ASSERT(!IsActive());
 }
 
 } }  // namespace v8::internal