third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp - Issue 1780723002: Enable Emoji Fitzpatrick modifier sequences

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

Issue 1780723002: Enable Emoji Fitzpatrick modifier sequences (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/fonts/Character.cpp ('K') | « third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaperTest.cpp ('k') | third_party/WebKit/Source/platform/fonts/shaping/RunSegmenterTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

index 71e9cd534e283a0c50cfaab1f22011b820d36206..16df7dde73ec0a42c9097b3dc874d51a90c481d7 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

+++ b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

@@ -108,8 +108,6 @@ static void normalizeCharacters(const TextRun& run, unsigned length, UChar* dest

character = spaceCharacter;

else if (Character::treatAsZeroWidthSpaceInComplexScript(character))

character = zeroWidthSpaceCharacter;

- else if (Character::isModifier(character))

- character = zeroWidthSpaceCharacter;

U16_APPEND(destination, *destinationLength, length, character, error);

ASSERT_UNUSED(error, !error);