Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 1780723002: Enable Emoji Fitzpatrick modifier sequences (Closed)

Created:
4 years, 9 months ago by drott
Modified:
4 years, 9 months ago
Reviewers:
kojii, eae
CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable Emoji Fitzpatrick modifier sequences * The CJK segmentation step in CachingWordShapeIterator should keep modifier sequences intact: Missing emoji need to be added to our CharacterData tables as well as allowing modifier characters as a continuation of CJK sequences in the nextWordEndIndex() step. * Disable blanking emoji modifier sequences in HarfBuzzShaper * Upgrade text code path from simple to complex for modifier characters, required for Android until Android switches to complex by default BUG=476377 R=kojii,eae Committed: https://crrev.com/184a32d58946f709f6f8c5b6037a772431be5530 Cr-Commit-Position: refs/heads/master@{#380399}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Comment and comparison fix for codepath choice #

Patch Set 3 : rebased on renamed CharacterData file #

Messages

Total messages: 19 (8 generated)
drott
4 years, 9 months ago (2016-03-09 19:18:24 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780723002/1
4 years, 9 months ago (2016-03-09 19:22:48 UTC) #3
eae
LGTM https://codereview.chromium.org/1780723002/diff/1/third_party/WebKit/Source/platform/fonts/Character.cpp File third_party/WebKit/Source/platform/fonts/Character.cpp (right): https://codereview.chromium.org/1780723002/diff/1/third_party/WebKit/Source/platform/fonts/Character.cpp#newcode201 third_party/WebKit/Source/platform/fonts/Character.cpp:201: if (supplementaryCharacter < 0x1F3FB) Could we add named ...
4 years, 9 months ago (2016-03-09 19:33:45 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/193910)
4 years, 9 months ago (2016-03-09 20:36:31 UTC) #6
drott
Comment and comparison fix for codepath choice
4 years, 9 months ago (2016-03-10 07:45:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780723002/20001
4 years, 9 months ago (2016-03-10 07:46:20 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/143007) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 9 months ago (2016-03-10 07:48:30 UTC) #12
drott
rebased on renamed CharacterData file
4 years, 9 months ago (2016-03-10 09:26:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780723002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780723002/40001
4 years, 9 months ago (2016-03-10 09:26:14 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-10 13:29:15 UTC) #17
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 13:31:28 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/184a32d58946f709f6f8c5b6037a772431be5530
Cr-Commit-Position: refs/heads/master@{#380399}

Powered by Google App Engine
This is Rietveld 408576698