components/password_manager/core/browser/login_database.cc - Issue 1780683002: Don't upload "null" to the Sync server for empty federation_url.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/login_database.cc

Issue 1780683002: Don't upload "null" to the Sync server for empty federation_url. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | components/password_manager/core/browser/password_syncable_service.cc » ('j') | components/password_manager/core/browser/password_syncable_service_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/login_database.cc

diff --git a/components/password_manager/core/browser/login_database.cc b/components/password_manager/core/browser/login_database.cc

index 9e781d524e93eddb3106d53eb9a1289044143afa..204db2e4ae7bba464e85d98481d02e116ae4d99b 100644

--- a/components/password_manager/core/browser/login_database.cc

+++ b/components/password_manager/core/browser/login_database.cc

@@ -141,7 +141,10 @@ void BindAddStatement(const PasswordForm& form,

s->BindInt64(COLUMN_DATE_SYNCED, form.date_synced.ToInternalValue());

s->BindString16(COLUMN_DISPLAY_NAME, form.display_name);

s->BindString(COLUMN_ICON_URL, form.icon_url.spec());

- s->BindString(COLUMN_FEDERATION_URL, form.federation_origin.Serialize());

+ s->BindString(COLUMN_FEDERATION_URL,

+ form.federation_origin.unique()

markusheintz_ 2016/03/09 18:02:59 opt: Add acomment describing why or simply referen

vasilii 2016/03/09 18:11:20 Done.

+ ? std::string()

+ : form.federation_origin.Serialize());

s->BindInt(COLUMN_SKIP_ZERO_CLICK, form.skip_zero_click);

s->BindInt(COLUMN_GENERATION_UPLOAD_STATUS, form.generation_upload_status);

}