third_party/WebKit/Source/core/layout/HitTestLocation.h - Issue 1780673002: Simplify CullRect computation in LineBoxList::hitTest; fixing off-by-one

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/HitTestLocation.h

Issue 1780673002: Simplify CullRect computation in LineBoxList::hitTest; fixing off-by-one (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@svg-text-hittest-no-floor

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/hittest/text-small-font-size-and-viewbox-expected.txt ('k') | third_party/WebKit/Source/core/layout/line/LineBoxList.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/HitTestLocation.h

diff --git a/third_party/WebKit/Source/core/layout/HitTestLocation.h b/third_party/WebKit/Source/core/layout/HitTestLocation.h

index a89241b79eecfdba0fcdb0339af89061368da07a..6fef9bd636127364585ee13fa2c743b62bcce7ed 100644

--- a/third_party/WebKit/Source/core/layout/HitTestLocation.h

+++ b/third_party/WebKit/Source/core/layout/HitTestLocation.h

@@ -62,10 +62,6 @@ public:

IntRect boundingBox() const { return m_boundingBox; }

static IntRect rectForPoint(const LayoutPoint&, unsigned topPadding, unsigned rightPadding, unsigned bottomPadding, unsigned leftPadding);

- int topPadding() const { return roundedPoint().y() - m_boundingBox.y(); }

- int rightPadding() const { return m_boundingBox.maxX() - roundedPoint().x() - 1; }

- int bottomPadding() const { return m_boundingBox.maxY() - roundedPoint().y() - 1; }

- int leftPadding() const { return roundedPoint().x() - m_boundingBox.x(); }

bool intersects(const LayoutRect&) const;

bool intersects(const FloatRect&) const;