Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: third_party/WebKit/LayoutTests/svg/hittest/text-small-font-size-and-viewbox.html

Issue 1780673002: Simplify CullRect computation in LineBoxList::hitTest; fixing off-by-one (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@svg-text-hittest-no-floor
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/svg/hittest/text-small-font-size-and-viewbox-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/svg/hittest/text-small-font-size-and-viewbox.html
diff --git a/third_party/WebKit/LayoutTests/svg/hittest/text-small-font-size-and-viewbox.html b/third_party/WebKit/LayoutTests/svg/hittest/text-small-font-size-and-viewbox.html
index 74f2ba3b41f2baceb3a87c67a3dfc878168c7473..564bece059d6a8edf0c3cef649f79d58e18c4dd1 100644
--- a/third_party/WebKit/LayoutTests/svg/hittest/text-small-font-size-and-viewbox.html
+++ b/third_party/WebKit/LayoutTests/svg/hittest/text-small-font-size-and-viewbox.html
@@ -13,12 +13,14 @@ svg {
width: 800px;
}
</style>
-<svg viewBox="0 0 22 28">
- <text font-family="Ahem" font-size="0.125" fill="blue" y="2.438"><a xlink:href="#">ABCDEFGH</a></text>
+<svg viewBox="0 0 22 28" font-family="Ahem" font-size="0.125" fill="blue">
+ <text y="2.438"><a xlink:href="#">ABCDEFGH</a></text>
+ <text y="4.698" x="7.571"><a xlink:href="#">ABCDEFGH</a></text>
</svg>
<script>
test(function() {
- var referenceElement = document.querySelector('a');
+ var links = document.querySelectorAll('a');
+
[
{ x: 2, y: 85 },
{ x: 4, y: 87 },
@@ -32,7 +34,21 @@ test(function() {
{ x: 22, y: 87 },
{ x: 26, y: 87 },
].forEach(function(point) {
- assert_equals(document.elementFromPoint(point.x, point.y), referenceElement, point.x + ',' + point.y);
+ assert_equals(document.elementFromPoint(point.x, point.y), links[0], point.x + ',' + point.y);
+ });
+
+ [
+ { x: 278, y: 169 },
+ { x: 276, y: 171 },
+ { x: 278, y: 169 },
+ { x: 280, y: 171 },
+ { x: 284, y: 169 },
+ { x: 288, y: 169 },
+ { x: 292, y: 169 },
+ { x: 296, y: 169 },
+ { x: 300, y: 169 },
+ ].forEach(function(point) {
+ assert_equals(document.elementFromPoint(point.x, point.y), links[1], point.x + ',' + point.y);
});
});
</script>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/svg/hittest/text-small-font-size-and-viewbox-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698