Issue 178065: NNTP cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 178065: NNTP cleanup (Closed)

Created:
11 years, 3 months ago by arv (Not doing code reviews)

Modified:
9 years, 4 months ago

Reviewers:
kuchhal, Miranda Callahan, idana

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google), Glen Murphy

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

NNTP cleanup - Fix bookmark sync background color - Make hidden elements not take up space at the bottom of the NNTP - Simplify sync and set as home page - Fix issue where middle clicking on the sync link opened a new tab BUG=19538 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25107

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -80 lines)			Patch
M	chrome/browser/resources/new_new_tab.css	View	1 2	4 chunks	+6 lines, -24 lines	0 comments	Download
M	chrome/browser/resources/new_new_tab.html	View	1	3 chunks	+15 lines, -12 lines	0 comments	Download
M	chrome/browser/resources/new_new_tab.js	View	1 2 3	5 chunks	+28 lines, -44 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Miranda Callahan

lvgtm. I am in the middle of a change to move and make smaller the ...

11 years, 3 months ago (2009-09-01 22:32:58 UTC) #2

lgtm. Thankyou!

Expand Messages | Collapse Messages