Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issue 178065: NNTP cleanup (Closed)

Created:
11 years, 3 months ago by arv (Not doing code reviews)
Modified:
9 years, 4 months ago
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google), Glen Murphy
Visibility:
Public.

Description

NNTP cleanup - Fix bookmark sync background color - Make hidden elements not take up space at the bottom of the NNTP - Simplify sync and set as home page - Fix issue where middle clicking on the sync link opened a new tab BUG=19538 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25107

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -80 lines) Patch
M chrome/browser/resources/new_new_tab.css View 1 2 4 chunks +6 lines, -24 lines 0 comments Download
M chrome/browser/resources/new_new_tab.html View 1 3 chunks +15 lines, -12 lines 0 comments Download
M chrome/browser/resources/new_new_tab.js View 1 2 3 5 chunks +28 lines, -44 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
arv (Not doing code reviews)
11 years, 3 months ago (2009-09-01 22:27:39 UTC) #1
Miranda Callahan
lvgtm. I am in the middle of a change to move and make smaller the ...
11 years, 3 months ago (2009-09-01 22:32:58 UTC) #2
idana
LGTM
11 years, 3 months ago (2009-09-01 22:42:19 UTC) #3
kuchhal
11 years, 3 months ago (2009-09-01 22:43:11 UTC) #4
lgtm. Thankyou!

Powered by Google App Engine
This is Rietveld 408576698